Support deletion in process.env too#5466
Support deletion in process.env too#5466mjesun merged 1 commit intojestjs:masterfrom mjesun:add-delete-to-process-env
Conversation
| // You can delete through case-insensitiveness too. | ||
| delete fake.prop_string; | ||
|
|
||
| expect('PROP_STRING' in fake).toBe(false); |
There was a problem hiding this comment.
expect(fake).not.toHaveProperty('PROP_STRING');?
Not sure if better or not
There was a problem hiding this comment.
Yeah, that could work too 🙂
|
|
||
| * `[jest-util]` Add deletion to `process.env` as well | ||
| ([#5466](https://github.com/facebook/jest/pull/5466)) | ||
| * `[jest-util]` Add case-insensitive getters/setters to `process.env` |
|
Lint failures on CI |
Codecov Report
@@ Coverage Diff @@
## master #5466 +/- ##
=========================================
Coverage ? 62.23%
=========================================
Files ? 205
Lines ? 6932
Branches ? 4
=========================================
Hits ? 4314
Misses ? 2617
Partials ? 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Get/Set behavior was implemented, but we lacked deletion. This PR adds it, along with some tests.