fix: simplify transform RegExp#10207
Conversation
Before
```
"^.+\\.[t|j]sx?$": "babel-jest"
```
After
```
"\\.[jt]sx?$": "babel-jest"
```
RegExp's `[]` doesn't need `|`, in fact, it adds it to the character list it looks for (`/[t|j]/.test('|') === true`). Also since we care only about the suffix, no reason for `^.+`.
elado
changed the title
|
Hi @elado! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Thanks! Should we update any code as well? E.g. https://github.com/facebook/jest/blob/e818dca70b1d314714a98e7ad79e8b73f1af9ec2/packages/jest-config/src/constants.ts#L11 and potentially other places
SimenB
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Summary
Before
After
RegExp's
[]doesn't need|, in fact, it adds it to the character list it looks for (/[t|j]/.test('|') === true). Also since we care only about the suffix, no reason for^.+.