fix changedFilesWithAncestor#4193
Merged
cpojer merged 1 commit intojestjs:masterfrom Aug 4, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4193 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 198 198
Lines 6781 6781
Branches 6 6
=======================================
Hits 4086 4086
Misses 2692 2692
Partials 3 3
Continue to review full report at Codecov.
|
Member
|
I would say that if it's a super edge-case, writing a test for it is super important ;) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding anything to
defaults.jsmakes it not overwritable :'(won't write a test cause it's a super edge case