Migrate jest-changed-files to Typescript#7827
Conversation
bfabad1 to
45a9d90
Compare
SimenB
left a comment
There was a problem hiding this comment.
Thanks again! I left some comments where I think we can be a bit stricter WRT types, but overall this is perfect
|
FYI incoming conflict: #7611. I'd like to merge that one first |
|
@Loryman it didn't cause conflicts since the file was copied - mind rebasing (making sure the copied types are correct) and addressing the nits? 🙂 |
|
@SimenB yeah sorry now i'm a bit busy, i can update and rebase everything in about 1 hour :) |
|
No rush |
06da425 to
b1f7738
Compare
Co-Authored-By: loryman <lorenzo.rapetti.94@gmail.com>
Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript
|
I've updated everything and made sure |
* Migrate jest-changed-files to Typescript * Add changelog entry * Update e2e/__tests__/jestChangedFiles.test.js Co-Authored-By: loryman <lorenzo.rapetti.94@gmail.com> * Stricter typings Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript * Make prettier happy
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Diff:
Details
Test plan
Green CI