chore: migrate jest-serializer to TypeScript#7841
Conversation
|
Changelog? |
|
Good call! |
|
|
||
| const v8s = [ | ||
| { | ||
| // @ts-ignore - Node 8+ only |
There was a problem hiding this comment.
Instead of disabling all those node 8 checks, you should mybe patch the node types.
declare namespace NodeJS {
interface v8 {
// ...
}
}
There was a problem hiding this comment.
Thanks! Added global.d.ts, hope it's ok? I'm new to TS :P
37fabc8 to
6a2b5ca
Compare
6a2b5ca to
1051cd7
Compare
Codecov Report
@@ Coverage Diff @@
## master #7841 +/- ##
==========================================
- Coverage 64.8% 64.63% -0.18%
==========================================
Files 230 229 -1
Lines 8657 8615 -42
Branches 5 5
==========================================
- Hits 5610 5568 -42
Misses 3045 3045
Partials 2 2Continue to review full report at Codecov.
|
Co-Authored-By: thymikee <thymikee@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Jumping on a TS train 🚂
Details
Test plan
Green CI