feat: print error msg & stack on preset normalization error#7935
feat: print error msg & stack on preset normalization error#7935SimenB merged 1 commit intojestjs:masterfrom
Conversation
wtho
force-pushed
the
feat/print-stack-preset-error
branch
from
962eb19 to
58ca8d6
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Looks good! Mind adding a changelog entry? :)
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
wtho
force-pushed
the
feat/print-stack-preset-error
branch
from
58ca8d6 to
e4ec36b
Compare
|
Update: Changed test Regex Is the changelog entry ok? |
|
Update 2: Simplified expected error message, as node v6 stacktraces it differently |
wtho
force-pushed
the
feat/print-stack-preset-error
branch
from
e4ec36b to
0d8e9fa
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Summary
When loading a
jest-preset.js, which does some computation or load other packages, errors can occur.This PR will help preset-developers to see the error message and stack. Currently only the misleading error message
Module jest-preset-angular should have "jest-preset.js" or "jest-preset.json" file at the root.is displayed.Inspired by thymikee/jest-preset-angular#230, kudos to @thymikee
Test plan
Unit test added