chore: cleanup JestEnvironment types#7988
Merged
SimenB merged 2 commits intojestjs:masterfrom Feb 26, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7988 +/- ##
=======================================
Coverage 64.54% 64.54%
=======================================
Files 257 257
Lines 10076 10076
Branches 1586 1587 +1
=======================================
Hits 6504 6504
Misses 3230 3230
Partials 342 342
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Played around with it in #7985, and these were the changes I had to make to allow us to do
class NodeEnvironment extends JestEnvironmentand get proper typingsTest plan
Green CI