Check for existence of Element when comparing DOM-nody-things (#7786) (clean cherry pick version)#7995
Merged
pedrottimark merged 8 commits intojestjs:masterfrom Mar 1, 2019
mfeineis:expect-dom-nodeenv-bug-7786-clean
Merged
Check for existence of Element when comparing DOM-nody-things (#7786) (clean cherry pick version)#7995pedrottimark merged 8 commits intojestjs:masterfrom mfeineis:expect-dom-nodeenv-bug-7786-clean
Element when comparing DOM-nody-things (#7786) (clean cherry pick version)#7995pedrottimark merged 8 commits intojestjs:masterfrom
mfeineis:expect-dom-nodeenv-bug-7786-clean
Conversation
pedrottimark
approved these changes
Feb 26, 2019
Contributor
pedrottimark
left a comment
pedrottimark
left a comment
There was a problem hiding this comment.
Looks good. Thank you for finding the problem and following through with a solution.
SimenB
approved these changes
Feb 27, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Could you update the changelog? Code LGTM 🙂
Contributor
Author
|
Done, it's always a pleasure to delete code with a PR 😄 |
Contributor
|
I pushed a change directly to your PR to replace 7786 with 7995 as text of link (the link was correct) As soon as CI passes again, I will merge. |
This was referenced Mar 5, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a clean spin-off of the current master with the meaningful commits cherry-picked on top made as a result of PR #7791
@pedrottimark I hope this is easier to handle than the rebased mess I made earlier 😄
SLA signed and still first contribution