fix 1-indexed JEST_WORKER_ID

[jeysal]

Summary

Fixes #8204
It's weird that it's 1-indexed (I looked at making our workerId 1-indexed too for consistency, but that would make our code really weird), but I guess it's documented, used to work like that and still does for runInBand 🤷‍♂️

Test plan

[codecov-io]

Codecov Report

Merging #8205 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8205   +/-   ##
======================================
  Coverage    62.3%   62.3%           
======================================
  Files         265     265           
  Lines       10473   10473           
  Branches     2542    2541    -1     
======================================
  Hits         6525    6525           
  Misses       3366    3366           
  Partials      582     582

Impacted Files	Coverage Δ
...ages/jest-worker/src/workers/ChildProcessWorker.ts	88.05% <ø> (ø)	⬆️
...kages/jest-worker/src/workers/NodeThreadsWorker.ts	89.23% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4e170...b042442. Read the comment docs.

[SimenB]

doing +1 in both implementations feels brittle, can't we fixed the number passed into the constructors instead? Wherever the count itself is kept (in a loop somewhere?) is where it should be corrected, not spread the logic around

[jeysal]

I tried but making workerId itself 1-indexed is terrible, it's used to index into an array. I'd love to just make everything 0-indexed but that's breaking

[jeysal]

And 0-indexed in the pool and 1-indexed in individual workers would be way more confusing than this

[SimenB]

I wasn't afraid of it being confusing, more about duplicating logic across multiple files. But if it's used as array accessors then I agree this should be fine

[SimenB]

Changelog, then we should be good

[jeysal]

Added changelog 👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.