chore: Remove repetition of matcherName and options in matchers

[pedrottimark]

Summary

Follow example of snapshot matchers in #8132

This pattern reduces chance of mistakes in remaining improvements to matchers

For example, when in this pull request I cut one of the existing literal objects for options in toBe and forgot to replace isNot: true with isNot: this.isNot until it broke some e2e tests

Also:

• replaced diffString with difference because it isn’t always a string
• replaced null with '' for secondArgument in toHaveProperty and removed 3 occurrences as MatcherHintOptions
• un-factored-out matcherHint call in toStrictEqual to call function only when test fails

Test plan

Updated snapshots in matchers.test.ts for not in regular black instead of dim:

• 23 for .not.toHaveProperty
• 22 for .not.toMatchObject

The matcher name in hint remains dim as clue that their reports are not yet improved.

Removed 'proxies matchers to expect' test according to #7970 (comment)

• packages/jest-jasmine2/src/__tests__/matchers.test.ts
• packages/jest-jasmine2/src/__tests__/__snapshots__/matchers.test.ts.snap

[SimenB]

I like it!

[codecov-io]

Codecov Report

Merging #8224 into master will increase coverage by 0.08%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master    #8224      +/-   ##
==========================================
+ Coverage   62.29%   62.38%   +0.08%     
==========================================
  Files         265      265              
  Lines       10551    10576      +25     
  Branches     2563     2564       +1     
==========================================
+ Hits         6573     6598      +25     
  Misses       3388     3388              
  Partials      590      590

Impacted Files	Coverage Δ
packages/expect/src/matchers.ts	96.02% <96.96%> (+0.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3483e...95a1e57. Read the comment docs.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.