Skip to content

Performance: use Map for jest-runtime module registry.#8232

Merged
scotthovestadt merged 2 commits intojestjs:masterfrom
scotthovestadt:optimize-runtime
Mar 29, 2019
Merged

Performance: use Map for jest-runtime module registry.#8232
scotthovestadt merged 2 commits intojestjs:masterfrom
scotthovestadt:optimize-runtime

Conversation

@scotthovestadt
Copy link
Copy Markdown
Contributor

Summary

Quick benchmark of getting Map vs Object for string keys of various lengths on Node v11:

  get object key x   278 ops/sec ±2.28% (85 runs sampled)
  get map key    x 1,716 ops/sec ±1.35% (93 runs sampled)

Test plan

  • All tests pass.
  • Tested against FB's test suite.

@scotthovestadt scotthovestadt changed the title Performance: use Map for jest-runtime mock registry. Performance: use Map for jest-runtime module registry. Mar 29, 2019
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants