Fix getting function name for rare cases#8362
Merged
SimenB merged 2 commits intojestjs:masterfrom Apr 23, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8362 +/- ##
==========================================
+ Coverage 62.27% 62.29% +0.02%
==========================================
Files 266 266
Lines 10728 10729 +1
Branches 2609 2608 -1
==========================================
+ Hits 6681 6684 +3
+ Misses 3462 3460 -2
Partials 585 585
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helper for getting function name in some cases returns wrong function name.
For example: If we somehow lost the property
namein function, then we used regExp that failed with async function, function generator and function with$in name.One more rare case if toString method was changed.
Test plan
I added tests for these cases