make watch plugin initialization errors look nice

[jeysal]

Summary

Follow up to jest-community/jest-watch-typeahead#29

Any idea how we could get rid of the outer stack trace and / or "Test suite failed to run"? In the current state it IMO looks worse than just the plain error. @SimenB
Edit: fixed outer stack trace, updated screenshot

Test plan

Added snapshot test.
Manual test -> see screenshot

[SimenB]

Any idea how we could get rid of the outer stack trace and / or "Test suite failed to run"?

const e = new Error(
  `Failed to initialize watch plugin '${
    pluginWithConfig.path
  }':\n\n${formatExecError(err, contexts[0].config, {
    noStackTrace: false,
  })}`,
);

// or `delete` it
e.stack = '';

return Promise.reject(e);

Does that work?

I like the "Test suite failed to run" text, just getting rid of the outer stack trace should make it nice and clean 🙂

[jeysal]

jest-cli accesses error.stack for some reason, that's why it didn't work when I tried (just printed undefined etc and I assumed it was coming from Node). I changed it, let's see if some e2e test complains about this.

[jeysal]

Ah, the good old absolute path on CI. Well, I'll take care of that tomorrow...

[SimenB]

Pass it through slash?

[jeysal]

I'll try that 👍

[SimenB]

CI is unhappy, but this lgtm. Really nice!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.