add jest.advanceTimersToNextTimer method#8713
Merged
SimenB merged 6 commits intojestjs:masterfrom Jul 28, 2019
Merged
Conversation
SimenB
requested changes
Jul 18, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
This is awesome, thank you so much for sending a PR!
SimenB
approved these changes
Jul 18, 2019
jeysal
approved these changes
Jul 21, 2019
3imed-jaberi
approved these changes
Jul 22, 2019
|
@thymikee please please please? |
This was referenced Aug 16, 2019
This was referenced Dec 31, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contribution by me and @deanshub
Summary
When you test a code (using fake timers) with lots of timeouts/intervals, and some of the code is 3rd party, it's hard to keep track of the right amount of milliseconds you should advance timers by.
Moreover, sometimes you don't want to run all the timers, because you might want to
expectsomething before the end of them all. (Maybe you need to assert between the second and third timeouts)jest.advanceTimersToNextTimerwill advance the timers by the correct milliseconds that make sense for the next assertion.The alternative is to run
jest.advanceTimersByTime(1)a lot of times until you ran the right amount to make your test pass (runAllTimerswill run too much timers).We tried this new feature on our tests and they look much cleaner.
Test plan
Added tests to
jest-fake-timers