expect: Improve report when negative CalledWith assertion fails

[pedrottimark]

Summary

For .not.toHaveBeen*CalledWith assertions:

• repeat not following Expected label
• replaced called with no arguments with called with 0 arguments to avoid double negative
• for special case of one call, display Received: whatever on one line
• but omit the line if received has same serialization as expected

Reason to separate pull requests:

• negative assertions adapt context logic from ReturnWith matchers in expect: Improve report when mock-spy matcher fails, part 4 #8710
• positive assertions will need design discussion about diff for object args

Test plan

Updated 40 snapshots

	long name	short name
2	toHaveBeenCalled	toBeCalled
12	toHaveBeenCalledWith	toBeCalledWith
12	toHaveBeenLastCalledWith	lastCalledWith
14	toHaveBeenNthCalledWith	nthCalledWith

See also pictures in following comment

Example pictures baseline at left and improved at right

[pedrottimark]

negative toHaveBeenCalledWith assertions:

negative toHaveBeenLastCalledWith assertions:

negative toHaveBeenNthCalledWith assertions:

[jeysal]

Very nice!

[pedrottimark]

What do you think about dim color for equal arguments in report for negative assertions?

In first example, current pull request above possible improvement:

P.S. Forgot to say before, scenario above is testing an imaginary reverse-order array method

In second and third examples, current pull request at left and possible improvement at right:

The reports for positive assertions will need dim color, so we might avoid extra code

[SimenB]

Oh yeah, dimming the parts that match makes a lot of sense to me

[jeysal]

Yes, looks very good 👌

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.