expect: Display equal values for ReturnedWith similar to CalledWith

[pedrottimark]

Summary

Display received value in dim color when it is equal to expected

Test plan

Updated 12 snapshots

	long name	short name
0	toHaveReturnedWith	toReturnWith
1	toHaveLastReturnedWith	lastReturnedWith
5	toHaveNthReturnedWith	nthReturnedWith

See also pictures in following comments

Example pictures baseline at left and improved at right if it changed

[pedrottimark]

negative toHaveReturnedWith assertions

positive toHaveReturnedWith assertions

[pedrottimark]

negative toHaveLastReturnedWith assertions

positive toHaveLastReturnedWith assertions

[pedrottimark]

negative toHaveNthReturnedWith assertions

positive toHaveNthReturnedWith assertions

[jeysal]

@pedrottimark Question: For not matchers, wouldn't it make more sense to show the equal values in red? To me, the red means "wrong" rather than "different"

[pedrottimark]

@jeysal That question caused me to wait until after we evaluated the convention for CalledWith because dim for matching versus red for not matching:

• can show contrast for negative LastReturnedWith or NthReturnedWith assertion fails, and maybe help decide whether the reason is incorrect call number in test, if preceding or adjacent context value also matches (dim) or not (red)
• cannot show contrast for negative ReturnedWith assertion because report displays only matching values, so I am open to viewpoint that consistency with the other matchers causes confusion or distraction that we can avoid with usual green versus red contrast for this matcher

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.