Calculate field initialization locally

Summary:
We talked in D85778435 about how we don't need to pass the initialization around.

I took a stab at it here at it here. Wondering if this looks better than the previous state?

Reviewed By: rchen152

Differential Revision: D86102369

fbshipit-source-id: ee11681b42de3e99c38e79b6197fc87e59ea52b3

Author: migeed-z

pyrefly/lib/alt/class/class_field.rs

@@ -184,7 +184,7 @@ pub enum DescriptorBase {
 ///
 /// TODO(stroxler): This type is mostly an artifact of a refactor, it used to be
 /// used in `BindingClassField`. We probably can eliminate it.
-enum RawClassFieldInitialization {
+pub enum RawClassFieldInitialization {
     /// At the point where the field is declared, it does not have an initial value. This includes
     /// fields declared but not initialized in the class body, and instance-only fields of
     /// synthesized classes.
@@ -1336,7 +1336,6 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
             name,
             direct_annotation.as_ref(),
             &ty,
-            &initialization,
             initial_value,
             descriptor.is_some(),
             range,
@@ -1430,7 +1429,6 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
         name: &Name,
         direct_annotation: Option<&Annotation>,
         ty: &Type,
-        initialization: &ClassFieldInitialization,
         initial_value: &RawClassFieldInitialization,
         is_descriptor: bool,
         range: TextRange,
@@ -1441,7 +1439,7 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
             name,
             direct_annotation,
             ty,
-            initialization,
+            initial_value,
             is_descriptor,
             range,
             errors,

pyrefly/lib/alt/class/enums.rs

@@ -23,7 +23,7 @@ use starlark_map::small_set::SmallSet;
 use crate::alt::answers::LookupAnswer;
 use crate::alt::answers_solver::AnswersSolver;
 use crate::alt::class::class_field::ClassAttribute;
-use crate::alt::class::class_field::ClassFieldInitialization;
+use crate::alt::class::class_field::RawClassFieldInitialization;
 use crate::alt::types::class_metadata::ClassMetadata;
 use crate::alt::types::class_metadata::EnumMetadata;
 use crate::error::collector::ErrorCollector;
@@ -55,15 +55,15 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
         &self,
         name: &Name,
         ty: &Type,
-        initialization: &ClassFieldInitialization,
+        initialization: &RawClassFieldInitialization,
     ) -> bool {
         // Names starting but not ending with __ are private
         // Names starting and ending with _ are reserved by the enum
         if Self::is_mangled_attr(name) || name.starts_with("_") && name.ends_with("_") {
             return false;
         }
         // Enum members must be initialized on the class
-        if !matches!(*initialization, ClassFieldInitialization::ClassBody(_)) {
+        if !matches!(*initialization, RawClassFieldInitialization::ClassBody(_)) {
             return false;
         }
         match ty {
@@ -225,7 +225,7 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
         name: &Name,
         direct_annotation: Option<&Annotation>,
         ty: &Type,
-        initialization: &ClassFieldInitialization,
+        initialization: &RawClassFieldInitialization,
         is_descriptor: bool,
         range: TextRange,
         errors: &ErrorCollector,