Skip to content

Commit 0a46e5e

Browse files
alexmalyshevfacebook-github-bot
authored andcommitted
Merge base AppleTVOS flags into base Apple flags (take #3)
Summary: Previous iterations of this diff that were reverted: D30678341 (8009459), D30868627 (abd0f38). With the power of selects, we can move the base AppleTVOS flags into the regular base Apple flags. While I'm here, drop the third `p` in `get_application_apppletvos_flags()` as it's driving me insane. Note - This puts get_visibility_option() on all Apple builds. I believe this is the right thing to do as everything except macOS static libraries already do it, and it shouldn't affect binaries. Changelog: [Internal] Reviewed By: mzlee, jdonald Differential Revision: D31024459 fbshipit-source-id: be85296cda3612836c1c74632dc52f6e3f89512e
1 parent 7df5f57 commit 0a46e5e

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

BUCK

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
2-
load("//tools/build_defs/apple:config_utils_defs.bzl", "STATIC_LIBRARY_APPLETVOS_CONFIG", "fbobjc_configs")
32
load("//tools/build_defs/apple:fb_apple_test.bzl", "fb_apple_test")
4-
load("//tools/build_defs/apple:flag_defs.bzl", "get_base_appletvos_flags", "get_objc_arc_preprocessor_flags", "get_preprocessor_flags_for_build_mode", "get_static_library_ios_flags")
3+
load("//tools/build_defs/apple:flag_defs.bzl", "get_objc_arc_preprocessor_flags", "get_preprocessor_flags_for_build_mode", "get_static_library_ios_flags")
54
load("//tools/build_defs/apple/plugins:plugin_defs.bzl", "plugin")
65
load("//tools/build_defs/oss:metro_defs.bzl", "rn_library")
76
load(
@@ -184,8 +183,6 @@ rn_xplat_cxx_library2(
184183
prefix = "React",
185184
),
186185
apple_sdks = (IOS, APPLETVOS),
187-
appletvos_configs = fbobjc_configs(STATIC_LIBRARY_APPLETVOS_CONFIG),
188-
appletvos_inherited_buck_flags = get_base_appletvos_flags(),
189186
contacts = ["oncall+react_native@xmail.facebook.com"],
190187
fbobjc_enable_exceptions = True,
191188
frameworks = [

0 commit comments

Comments
 (0)