Commit 3f7e0a2
Removing <TextInput>'s
Summary:
This is the first diff in the series. It removes Flow types for this feature to verify that we actually do not have any usages. After it lands, we will remove actual support on the native side.
There are several reasons why removing it is a good idea:
* There is no any evidence that this feature is actually useful. That was discussed several times (e.g. see T7936714) during RN lifetime and the overall consensus is: We need something else, something like sync `onChange` event instead of it.
* Supporting the previous point, it's not used (at least inside Facebook). I searched hard and I could find only one place where it's used: in the TextInput Example.
* To deliver more functionality we should lean towards W3C specs, this one is not W3C compliant.
* Supporting this Feature in Fabric is quite challenging, so I want to do it sooner than later.
* This feature was never documented.
Changelog: [Breaking] `<TextInput>::onTextInput` event was removed
Reviewed By: TheSavior
Differential Revision: D18456175
fbshipit-source-id: c7a8ed7a86b33ecc01d45497645fe249556fdf96onTextInput event1 parent 9f0b80b commit 3f7e0a2
1 file changed
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
548 | 548 | | |
549 | 549 | | |
550 | 550 | | |
551 | | - | |
552 | | - | |
553 | 551 | | |
554 | 552 | | |
555 | 553 | | |
| |||
948 | 946 | | |
949 | 947 | | |
950 | 948 | | |
951 | | - | |
952 | 949 | | |
953 | 950 | | |
954 | 951 | | |
| |||
983 | 980 | | |
984 | 981 | | |
985 | 982 | | |
986 | | - | |
987 | 983 | | |
988 | 984 | | |
989 | 985 | | |
| |||
1111 | 1107 | | |
1112 | 1108 | | |
1113 | 1109 | | |
1114 | | - | |
1115 | | - | |
1116 | | - | |
1117 | | - | |
1118 | 1110 | | |
1119 | 1111 | | |
1120 | 1112 | | |
| |||
0 commit comments