Skip to content

Commit 7131f94

Browse files
Fabrizio Cuccifacebook-github-bot
authored andcommitted
Revert D55964787: Push ReactContext logic in derived classes
Differential Revision: D55964787 Original commit changeset: b404efe0c709 Original Phabricator Diff: D55964787 fbshipit-source-id: 0742b9aa870a08fed603cf6f33774d4813f5050c
1 parent b7812a8 commit 7131f94

6 files changed

Lines changed: 200 additions & 349 deletions

File tree

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 22 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -543,25 +543,8 @@ public abstract class com/facebook/react/bridge/BaseJavaModule : com/facebook/re
543543
public fun invalidate ()V
544544
}
545545

546-
public class com/facebook/react/bridge/BridgeReactContext : com/facebook/react/bridge/ReactApplicationContext {
546+
public final class com/facebook/react/bridge/BridgeReactContext : com/facebook/react/bridge/ReactApplicationContext {
547547
public fun <init> (Landroid/content/Context;)V
548-
public fun destroy ()V
549-
public fun getCatalystInstance ()Lcom/facebook/react/bridge/CatalystInstance;
550-
public fun getFabricUIManager ()Lcom/facebook/react/bridge/UIManager;
551-
public fun getJSModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/JavaScriptModule;
552-
public fun getJavaScriptContextHolder ()Lcom/facebook/react/bridge/JavaScriptContextHolder;
553-
public fun getNativeModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/NativeModule;
554-
public fun getNativeModules ()Ljava/util/Collection;
555-
public fun getRuntimeExecutor ()Lcom/facebook/react/bridge/RuntimeExecutor;
556-
public fun getSourceURL ()Ljava/lang/String;
557-
public fun handleException (Ljava/lang/Exception;)V
558-
public fun hasActiveCatalystInstance ()Z
559-
public fun hasActiveReactInstance ()Z
560-
public fun hasCatalystInstance ()Z
561-
public fun hasNativeModule (Ljava/lang/Class;)Z
562-
public fun initializeWithInstance (Lcom/facebook/react/bridge/CatalystInstance;)V
563-
public fun isBridgeless ()Z
564-
public fun registerSegment (ILjava/lang/String;Lcom/facebook/react/bridge/Callback;)V
565548
}
566549

567550
public abstract interface class com/facebook/react/bridge/Callback {
@@ -1107,35 +1090,36 @@ public abstract class com/facebook/react/bridge/ReactContext : android/content/C
11071090
public fun assertOnNativeModulesQueueThread ()V
11081091
public fun assertOnNativeModulesQueueThread (Ljava/lang/String;)V
11091092
public fun assertOnUiQueueThread ()V
1110-
public abstract fun destroy ()V
1093+
public fun destroy ()V
11111094
public fun emitDeviceEvent (Ljava/lang/String;)V
11121095
public fun emitDeviceEvent (Ljava/lang/String;Ljava/lang/Object;)V
1113-
public abstract fun getCatalystInstance ()Lcom/facebook/react/bridge/CatalystInstance;
1096+
public fun getCatalystInstance ()Lcom/facebook/react/bridge/CatalystInstance;
11141097
public fun getCurrentActivity ()Landroid/app/Activity;
11151098
public fun getExceptionHandler ()Lcom/facebook/react/bridge/JSExceptionHandler;
1116-
public abstract fun getFabricUIManager ()Lcom/facebook/react/bridge/UIManager;
1099+
public fun getFabricUIManager ()Lcom/facebook/react/bridge/UIManager;
11171100
public fun getJSExceptionHandler ()Lcom/facebook/react/bridge/JSExceptionHandler;
11181101
public fun getJSMessageQueueThread ()Lcom/facebook/react/bridge/queue/MessageQueueThread;
1119-
public abstract fun getJSModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/JavaScriptModule;
1120-
public abstract fun getJavaScriptContextHolder ()Lcom/facebook/react/bridge/JavaScriptContextHolder;
1102+
public fun getJSModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/JavaScriptModule;
1103+
public fun getJavaScriptContextHolder ()Lcom/facebook/react/bridge/JavaScriptContextHolder;
11211104
public fun getLifecycleState ()Lcom/facebook/react/common/LifecycleState;
1122-
public abstract fun getNativeModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/NativeModule;
1123-
public abstract fun getNativeModules ()Ljava/util/Collection;
1105+
public fun getNativeModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/NativeModule;
1106+
public fun getNativeModules ()Ljava/util/Collection;
11241107
public fun getNativeModulesMessageQueueThread ()Lcom/facebook/react/bridge/queue/MessageQueueThread;
1125-
public abstract fun getSourceURL ()Ljava/lang/String;
1108+
public fun getSourceURL ()Ljava/lang/String;
11261109
public fun getSystemService (Ljava/lang/String;)Ljava/lang/Object;
11271110
public fun getUiMessageQueueThread ()Lcom/facebook/react/bridge/queue/MessageQueueThread;
1128-
public abstract fun handleException (Ljava/lang/Exception;)V
1129-
public abstract fun hasActiveCatalystInstance ()Z
1130-
public abstract fun hasActiveReactInstance ()Z
1131-
public abstract fun hasCatalystInstance ()Z
1111+
public fun handleException (Ljava/lang/Exception;)V
1112+
public fun hasActiveCatalystInstance ()Z
1113+
public fun hasActiveReactInstance ()Z
1114+
public fun hasCatalystInstance ()Z
11321115
public fun hasCurrentActivity ()Z
1133-
public abstract fun hasNativeModule (Ljava/lang/Class;)Z
1134-
protected fun initializeFromOther (Lcom/facebook/react/bridge/ReactContext;)V
1116+
public fun hasNativeModule (Ljava/lang/Class;)Z
11351117
protected fun initializeInteropModules ()V
1118+
protected fun initializeInteropModules (Lcom/facebook/react/bridge/ReactContext;)V
11361119
public fun initializeMessageQueueThreads (Lcom/facebook/react/bridge/queue/ReactQueueConfiguration;)V
1120+
public fun initializeWithInstance (Lcom/facebook/react/bridge/CatalystInstance;)V
11371121
public fun internal_registerInteropModule (Ljava/lang/Class;Ljava/lang/Object;)V
1138-
public abstract fun isBridgeless ()Z
1122+
public fun isBridgeless ()Z
11391123
public fun isOnJSQueueThread ()Z
11401124
public fun isOnNativeModulesQueueThread ()Z
11411125
public fun isOnUiQueueThread ()Z
@@ -1145,7 +1129,7 @@ public abstract class com/facebook/react/bridge/ReactContext : android/content/C
11451129
public fun onHostResume (Landroid/app/Activity;)V
11461130
public fun onNewIntent (Landroid/app/Activity;Landroid/content/Intent;)V
11471131
public fun onWindowFocusChange (Z)V
1148-
public abstract fun registerSegment (ILjava/lang/String;Lcom/facebook/react/bridge/Callback;)V
1132+
public fun registerSegment (ILjava/lang/String;Lcom/facebook/react/bridge/Callback;)V
11491133
public fun removeActivityEventListener (Lcom/facebook/react/bridge/ActivityEventListener;)V
11501134
public fun removeLifecycleEventListener (Lcom/facebook/react/bridge/LifecycleEventListener;)V
11511135
public fun removeWindowFocusChangeListener (Lcom/facebook/react/bridge/WindowFocusChangeListener;)V
@@ -4909,25 +4893,16 @@ public class com/facebook/react/uimanager/ThemedReactContext : com/facebook/reac
49094893
public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Landroid/content/Context;)V
49104894
public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Landroid/content/Context;Ljava/lang/String;)V
49114895
public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Landroid/content/Context;Ljava/lang/String;I)V
4912-
public fun destroy ()V
4913-
public fun getCatalystInstance ()Lcom/facebook/react/bridge/CatalystInstance;
4896+
public fun addLifecycleEventListener (Lcom/facebook/react/bridge/LifecycleEventListener;)V
4897+
public fun getCurrentActivity ()Landroid/app/Activity;
49144898
public fun getFabricUIManager ()Lcom/facebook/react/bridge/UIManager;
4915-
public fun getJSModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/JavaScriptModule;
4916-
public fun getJavaScriptContextHolder ()Lcom/facebook/react/bridge/JavaScriptContextHolder;
49174899
public fun getModuleName ()Ljava/lang/String;
4918-
public fun getNativeModule (Ljava/lang/Class;)Lcom/facebook/react/bridge/NativeModule;
4919-
public fun getNativeModules ()Ljava/util/Collection;
49204900
public fun getReactApplicationContext ()Lcom/facebook/react/bridge/ReactApplicationContext;
4921-
public fun getSourceURL ()Ljava/lang/String;
49224901
public fun getSurfaceID ()Ljava/lang/String;
49234902
public fun getSurfaceId ()I
4924-
public fun handleException (Ljava/lang/Exception;)V
4925-
public fun hasActiveCatalystInstance ()Z
4926-
public fun hasActiveReactInstance ()Z
4927-
public fun hasCatalystInstance ()Z
4928-
public fun hasNativeModule (Ljava/lang/Class;)Z
4903+
public fun hasCurrentActivity ()Z
49294904
public fun isBridgeless ()Z
4930-
public fun registerSegment (ILjava/lang/String;Lcom/facebook/react/bridge/Callback;)V
4905+
public fun removeLifecycleEventListener (Lcom/facebook/react/bridge/LifecycleEventListener;)V
49314906
}
49324907

49334908
public class com/facebook/react/uimanager/TouchTargetHelper {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BridgeReactContext.java

Lines changed: 0 additions & 189 deletions
This file was deleted.
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*/
7+
8+
package com.facebook.react.bridge
9+
10+
import android.content.Context
11+
import com.facebook.react.common.annotations.DeprecatedInNewArchitecture
12+
13+
/**
14+
* This is the bridge-specific concrete subclass of ReactContext. ReactContext has many methods that
15+
* delegate to the react instance. This subclass will implement those methods, by delegating to the
16+
* CatalystInstance. If you need to create a ReactContext within an "bridge context", please create
17+
* BridgeReactContext.
18+
*/
19+
@DeprecatedInNewArchitecture
20+
public class BridgeReactContext(base: Context) : ReactApplicationContext(base) {}

0 commit comments

Comments
 (0)