Fix - ReconnectingWebSocket race condition mClosed

Summary:
Changelog : [Internal]
Use synchronized blocks to avoid race conditions surrounding mClosed.

Reviewed By: makovkastar

Differential Revision: D31019994

fbshipit-source-id: 48793bd3bea98224d8df344bc4fc8771b517cf72

Author: amy588

ReactAndroid/src/main/java/com/facebook/react/packagerconnection/ReconnectingWebSocket.java

@@ -66,8 +66,10 @@ public ReconnectingWebSocket(
   }
 
   public void connect() {
-    if (mClosed) {
-      throw new IllegalStateException("Can't connect closed client");
+    synchronized (this) {
+      if (mClosed) {
+        throw new IllegalStateException("Can't connect closed client");
+      }
     }
 
     Request request = new Request.Builder().url(mUrl).build();
@@ -82,8 +84,10 @@ private synchronized void delayedReconnect() {
   }
 
   private void reconnect() {
-    if (mClosed) {
-      throw new IllegalStateException("Can't reconnect closed client");
+    synchronized (this) {
+      if (mClosed) {
+        throw new IllegalStateException("Can't reconnect closed client");
+      }
     }
 
     if (!mSuppressConnectionErrors) {
@@ -102,8 +106,10 @@ public void run() {
   }
 
   public void closeQuietly() {
-    mClosed = true;
-    closeWebSocketQuietly();
+    synchronized (this) {
+      mClosed = true;
+      closeWebSocketQuietly();
+    }
     mMessageCallback = null;
 
     if (mConnectionCallback != null) {