Skip to content

Commit d0cac87

Browse files
TatianaKaposfacebook-github-bot
authored andcommitted
Fix [Windows]: Rename utils/jsi files (#43700)
Summary: This PR: https://github.com/facebook/react-native/pull/42801/files#diff-ff466c93fb60f2b0e79ed187f492c9935349a2b2f2a7300b310e2bb30e31c33e creates a new jsi.h and jsi.cpp file in ReactCommon. On windows, even though the files have different paths, MSVC doesn't allow two files to have the same name in the same project. This PR changes the name of the new jsi.h and jsi.cpp files. ## Changelog: [General][Fixed] - Rename utils/jsi files Pull Request resolved: #43700 Test Plan: tested on windows Reviewed By: zeyap Differential Revision: D55491700 Pulled By: arushikesarwani94 fbshipit-source-id: 2995c0602a9528ed0f8e8eb2230945cb6bd516e9
1 parent f7ec469 commit d0cac87

4 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "TurboModuleBinding.h"
99

1010
#include <cxxreact/SystraceSection.h>
11-
#include <react/utils/jsi.h>
11+
#include <react/utils/jsi-utils.h>
1212
#include <stdexcept>
1313
#include <string>
1414

packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include <jsireact/JSIExecutor.h>
2121
#include <react/featureflags/ReactNativeFeatureFlags.h>
2222
#include <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
23-
#include <react/utils/jsi.h>
23+
#include <react/utils/jsi-utils.h>
2424
#include <iostream>
2525
#include <memory>
2626
#include <tuple>

packages/react-native/ReactCommon/react/utils/jsi.cpp renamed to packages/react-native/ReactCommon/react/utils/jsi-utils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include "jsi.h"
8+
#include "jsi-utils.h"
99

1010
namespace facebook::react {
1111

packages/react-native/ReactCommon/react/utils/jsi.h renamed to packages/react-native/ReactCommon/react/utils/jsi-utils.h

File renamed without changes.

0 commit comments

Comments
 (0)