Skip to content

Commit 134a502

Browse files
eps1loneps1lon
committed
[Flight] Fix wrong missing key warning when static child is blocked (#34350)
DiffTrain build for [bb6f0c8](bb6f0c8)
1 parent 7838606 commit 134a502

36 files changed

Lines changed: 140 additions & 98 deletions

‎compiled/facebook-www/JSXDEVRuntime-dev.classic.js‎

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,23 @@ __DEV__ &&
271271
);
272272
}
273273
function validateChildKeys(node) {
274-
"object" === typeof node &&
275-
null !== node &&
276-
node.$$typeof === REACT_ELEMENT_TYPE &&
277-
node._store &&
278-
(node._store.validated = 1);
274+
isValidElement(node)
275+
? node._store && (node._store.validated = 1)
276+
: "object" === typeof node &&
277+
null !== node &&
278+
node.$$typeof === REACT_LAZY_TYPE &&
279+
("fulfilled" === node._payload.status
280+
? isValidElement(node._payload.value) &&
281+
node._payload.value._store &&
282+
(node._payload.value._store.validated = 1)
283+
: node._store && (node._store.validated = 1));
284+
}
285+
function isValidElement(object) {
286+
return (
287+
"object" === typeof object &&
288+
null !== object &&
289+
object.$$typeof === REACT_ELEMENT_TYPE
290+
);
279291
}
280292
var React = require("react"),
281293
dynamicFeatureFlags = require("ReactFeatureFlags"),

‎compiled/facebook-www/JSXDEVRuntime-dev.modern.js‎

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,23 @@ __DEV__ &&
271271
);
272272
}
273273
function validateChildKeys(node) {
274-
"object" === typeof node &&
275-
null !== node &&
276-
node.$$typeof === REACT_ELEMENT_TYPE &&
277-
node._store &&
278-
(node._store.validated = 1);
274+
isValidElement(node)
275+
? node._store && (node._store.validated = 1)
276+
: "object" === typeof node &&
277+
null !== node &&
278+
node.$$typeof === REACT_LAZY_TYPE &&
279+
("fulfilled" === node._payload.status
280+
? isValidElement(node._payload.value) &&
281+
node._payload.value._store &&
282+
(node._payload.value._store.validated = 1)
283+
: node._store && (node._store.validated = 1));
284+
}
285+
function isValidElement(object) {
286+
return (
287+
"object" === typeof object &&
288+
null !== object &&
289+
object.$$typeof === REACT_ELEMENT_TYPE
290+
);
279291
}
280292
var React = require("react"),
281293
dynamicFeatureFlags = require("ReactFeatureFlags"),

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4082b0e7d3c042d49ef8987547b923051936956f
1+
bb6f0c8d2f29754347db0ff28186dc89c128b6ca

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4082b0e7d3c042d49ef8987547b923051936956f
1+
bb6f0c8d2f29754347db0ff28186dc89c128b6ca

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,16 @@ __DEV__ &&
331331
return newKey;
332332
}
333333
function validateChildKeys(node) {
334-
isValidElement(node) && node._store && (node._store.validated = 1);
334+
isValidElement(node)
335+
? node._store && (node._store.validated = 1)
336+
: "object" === typeof node &&
337+
null !== node &&
338+
node.$$typeof === REACT_LAZY_TYPE &&
339+
("fulfilled" === node._payload.status
340+
? isValidElement(node._payload.value) &&
341+
node._payload.value._store &&
342+
(node._payload.value._store.validated = 1)
343+
: node._store && (node._store.validated = 1));
335344
}
336345
function isValidElement(object) {
337346
return (
@@ -1409,7 +1418,7 @@ __DEV__ &&
14091418
exports.useTransition = function () {
14101419
return resolveDispatcher().useTransition();
14111420
};
1412-
exports.version = "19.2.0-www-classic-4082b0e7-20250828";
1421+
exports.version = "19.2.0-www-classic-bb6f0c8d-20250901";
14131422
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14141423
"function" ===
14151424
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,16 @@ __DEV__ &&
331331
return newKey;
332332
}
333333
function validateChildKeys(node) {
334-
isValidElement(node) && node._store && (node._store.validated = 1);
334+
isValidElement(node)
335+
? node._store && (node._store.validated = 1)
336+
: "object" === typeof node &&
337+
null !== node &&
338+
node.$$typeof === REACT_LAZY_TYPE &&
339+
("fulfilled" === node._payload.status
340+
? isValidElement(node._payload.value) &&
341+
node._payload.value._store &&
342+
(node._payload.value._store.validated = 1)
343+
: node._store && (node._store.validated = 1));
335344
}
336345
function isValidElement(object) {
337346
return (
@@ -1409,7 +1418,7 @@ __DEV__ &&
14091418
exports.useTransition = function () {
14101419
return resolveDispatcher().useTransition();
14111420
};
1412-
exports.version = "19.2.0-www-modern-4082b0e7-20250828";
1421+
exports.version = "19.2.0-www-modern-bb6f0c8d-20250901";
14131422
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14141423
"function" ===
14151424
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,4 +600,4 @@ exports.useSyncExternalStore = function (
600600
exports.useTransition = function () {
601601
return ReactSharedInternals.H.useTransition();
602602
};
603-
exports.version = "19.2.0-www-classic-4082b0e7-20250828";
603+
exports.version = "19.2.0-www-classic-bb6f0c8d-20250901";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,4 +600,4 @@ exports.useSyncExternalStore = function (
600600
exports.useTransition = function () {
601601
return ReactSharedInternals.H.useTransition();
602602
};
603-
exports.version = "19.2.0-www-modern-4082b0e7-20250828";
603+
exports.version = "19.2.0-www-modern-bb6f0c8d-20250901";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.2.0-www-classic-4082b0e7-20250828";
607+
exports.version = "19.2.0-www-classic-bb6f0c8d-20250901";
608608
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
609609
"function" ===
610610
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.2.0-www-modern-4082b0e7-20250828";
607+
exports.version = "19.2.0-www-modern-bb6f0c8d-20250901";
608608
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
609609
"function" ===
610610
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)
⚡