Skip to content

Commit 8cc2b72

Browse files
yungstersyungsters
committed
Add alwaysThrottleDisappearingFallbacks Flag (#28550)
## Summary Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that gates the changes from #26802 (instead of being controlled by `alwaysThrottleRetries`). The values of this new flag mirror the current values of `alwaysThrottleRetries` such that there is no behavior difference. This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from `alwaysThrottleRetries`. ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ``` DiffTrain build for [0aab065](0aab065)
1 parent 187dc16 commit 8cc2b72

19 files changed

Lines changed: 81 additions & 51 deletions

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4d686a2da138cad9e76c7de9feadd81ca2aa29e5
1+
0aab065eb3250a9714a62dc05587cbb571da7f71

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,4 +633,4 @@ exports.useSyncExternalStore = function (
633633
exports.useTransition = function () {
634634
return ReactCurrentDispatcher.current.useTransition();
635635
};
636-
exports.version = "18.3.0-www-classic-a611e792";
636+
exports.version = "18.3.0-www-classic-829f825d";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ exports.useSyncExternalStore = function (
637637
exports.useTransition = function () {
638638
return ReactCurrentDispatcher.current.useTransition();
639639
};
640-
exports.version = "18.3.0-www-classic-b0205e8a";
640+
exports.version = "18.3.0-www-classic-29031ba7";
641641
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
642642
"function" ===
643643
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-classic-7fbd8e77";
69+
var ReactVersion = "18.3.0-www-classic-a2c6275a";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -172,6 +172,8 @@ if (__DEV__) {
172172
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
173173
enableDeferRootSchedulingToMicrotask =
174174
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
175+
alwaysThrottleDisappearingFallbacks =
176+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
175177
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
176178
enableDO_NOT_USE_disableStrictPassiveEffect =
177179
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -23164,7 +23166,7 @@ if (__DEV__) {
2316423166
var wasShowingFallback =
2316523167
current !== null && current.memoizedState !== null;
2316623168

23167-
if (alwaysThrottleRetries) {
23169+
if (alwaysThrottleDisappearingFallbacks) {
2316823170
if (isShowingFallback !== wasShowingFallback) {
2316923171
// A fallback is either appearing or disappearing.
2317023172
markCommitTimeOfFallback();

‎compiled/facebook-www/ReactART-dev.modern.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-modern-b0c54115";
69+
var ReactVersion = "18.3.0-www-modern-f2f5c035";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -172,6 +172,8 @@ if (__DEV__) {
172172
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
173173
enableDeferRootSchedulingToMicrotask =
174174
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
175+
alwaysThrottleDisappearingFallbacks =
176+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
175177
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
176178
enableDO_NOT_USE_disableStrictPassiveEffect =
177179
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -22823,7 +22825,7 @@ if (__DEV__) {
2282322825
var wasShowingFallback =
2282422826
current !== null && current.memoizedState !== null;
2282522827

22826-
if (alwaysThrottleRetries) {
22828+
if (alwaysThrottleDisappearingFallbacks) {
2282722829
if (isShowingFallback !== wasShowingFallback) {
2282822830
// A fallback is either appearing or disappearing.
2282922831
markCommitTimeOfFallback();

‎compiled/facebook-www/ReactART-prod.classic.js‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ var ReactSharedInternals =
7171
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
7272
enableDeferRootSchedulingToMicrotask =
7373
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
74+
alwaysThrottleDisappearingFallbacks =
75+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
7476
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
7577
enableDO_NOT_USE_disableStrictPassiveEffect =
7678
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -7996,7 +7998,7 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
79967998
finishedWork.child.flags & 8192 &&
79977999
((newProps = null !== finishedWork.memoizedState),
79988000
(current = null !== current && null !== current.memoizedState),
7999-
alwaysThrottleRetries
8001+
alwaysThrottleDisappearingFallbacks
80008002
? newProps !== current && (globalMostRecentFallbackTime = now())
80018003
: newProps && !current && (globalMostRecentFallbackTime = now()));
80028004
if (flags & 4) {
@@ -10626,7 +10628,7 @@ var slice = Array.prototype.slice,
1062610628
return null;
1062710629
},
1062810630
bundleType: 0,
10629-
version: "18.3.0-www-classic-4fbf3623",
10631+
version: "18.3.0-www-classic-d82b0a84",
1063010632
rendererPackageName: "react-art"
1063110633
};
1063210634
var internals$jscomp$inline_1320 = {
@@ -10657,7 +10659,7 @@ var internals$jscomp$inline_1320 = {
1065710659
scheduleRoot: null,
1065810660
setRefreshHandler: null,
1065910661
getCurrentFiber: null,
10660-
reconcilerVersion: "18.3.0-www-classic-4fbf3623"
10662+
reconcilerVersion: "18.3.0-www-classic-d82b0a84"
1066110663
};
1066210664
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1066310665
var hook$jscomp$inline_1321 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactART-prod.modern.js‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ var ReactSharedInternals =
7171
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
7272
enableDeferRootSchedulingToMicrotask =
7373
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
74+
alwaysThrottleDisappearingFallbacks =
75+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
7476
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
7577
enableDO_NOT_USE_disableStrictPassiveEffect =
7678
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -7695,7 +7697,7 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
76957697
finishedWork.child.flags & 8192 &&
76967698
((newProps = null !== finishedWork.memoizedState),
76977699
(current = null !== current && null !== current.memoizedState),
7698-
alwaysThrottleRetries
7700+
alwaysThrottleDisappearingFallbacks
76997701
? newProps !== current && (globalMostRecentFallbackTime = now())
77007702
: newProps && !current && (globalMostRecentFallbackTime = now()));
77017703
if (flags & 4) {
@@ -10281,7 +10283,7 @@ var slice = Array.prototype.slice,
1028110283
return null;
1028210284
},
1028310285
bundleType: 0,
10284-
version: "18.3.0-www-modern-3c5debba",
10286+
version: "18.3.0-www-modern-1cdbdb89",
1028510287
rendererPackageName: "react-art"
1028610288
};
1028710289
var internals$jscomp$inline_1300 = {
@@ -10312,7 +10314,7 @@ var internals$jscomp$inline_1300 = {
1031210314
scheduleRoot: null,
1031310315
setRefreshHandler: null,
1031410316
getCurrentFiber: null,
10315-
reconcilerVersion: "18.3.0-www-modern-3c5debba"
10317+
reconcilerVersion: "18.3.0-www-modern-1cdbdb89"
1031610318
};
1031710319
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1031810320
var hook$jscomp$inline_1301 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactDOM-dev.classic.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,8 @@ if (__DEV__) {
137137
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
138138
enableDeferRootSchedulingToMicrotask =
139139
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
140+
alwaysThrottleDisappearingFallbacks =
141+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
140142
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
141143
enableDO_NOT_USE_disableStrictPassiveEffect =
142144
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -28915,7 +28917,7 @@ if (__DEV__) {
2891528917
var wasShowingFallback =
2891628918
current !== null && current.memoizedState !== null;
2891728919

28918-
if (alwaysThrottleRetries) {
28920+
if (alwaysThrottleDisappearingFallbacks) {
2891928921
if (isShowingFallback !== wasShowingFallback) {
2892028922
// A fallback is either appearing or disappearing.
2892128923
markCommitTimeOfFallback();
@@ -35785,7 +35787,7 @@ if (__DEV__) {
3578535787
return root;
3578635788
}
3578735789

35788-
var ReactVersion = "18.3.0-www-classic-d282d81a";
35790+
var ReactVersion = "18.3.0-www-classic-e5fe653a";
3578935791

3579035792
function createPortal$1(
3579135793
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ if (__DEV__) {
132132
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
133133
enableDeferRootSchedulingToMicrotask =
134134
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
135+
alwaysThrottleDisappearingFallbacks =
136+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
135137
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
136138
enableDO_NOT_USE_disableStrictPassiveEffect =
137139
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -28771,7 +28773,7 @@ if (__DEV__) {
2877128773
var wasShowingFallback =
2877228774
current !== null && current.memoizedState !== null;
2877328775

28774-
if (alwaysThrottleRetries) {
28776+
if (alwaysThrottleDisappearingFallbacks) {
2877528777
if (isShowingFallback !== wasShowingFallback) {
2877628778
// A fallback is either appearing or disappearing.
2877728779
markCommitTimeOfFallback();
@@ -35632,7 +35634,7 @@ if (__DEV__) {
3563235634
return root;
3563335635
}
3563435636

35635-
var ReactVersion = "18.3.0-www-modern-a7e0f9ae";
35637+
var ReactVersion = "18.3.0-www-modern-a3956207";
3563635638

3563735639
function createPortal$1(
3563835640
children,

‎compiled/facebook-www/ReactDOM-prod.classic.js‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ var ReactSharedInternals =
5050
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
5151
enableDeferRootSchedulingToMicrotask =
5252
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
53+
alwaysThrottleDisappearingFallbacks =
54+
dynamicFeatureFlags.alwaysThrottleDisappearingFallbacks,
5355
alwaysThrottleRetries = dynamicFeatureFlags.alwaysThrottleRetries,
5456
enableDO_NOT_USE_disableStrictPassiveEffect =
5557
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -9774,7 +9776,7 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
97749776
finishedWork.child.flags & 8192 &&
97759777
((root = null !== finishedWork.memoizedState),
97769778
(current = null !== current && null !== current.memoizedState),
9777-
alwaysThrottleRetries
9779+
alwaysThrottleDisappearingFallbacks
97789780
? root !== current && (globalMostRecentFallbackTime = now())
97799781
: root && !current && (globalMostRecentFallbackTime = now()));
97809782
if (flags & 4) {
@@ -17234,7 +17236,7 @@ Internals.Events = [
1723417236
var devToolsConfig$jscomp$inline_1817 = {
1723517237
findFiberByHostInstance: getClosestInstanceFromNode,
1723617238
bundleType: 0,
17237-
version: "18.3.0-www-classic-28494f4a",
17239+
version: "18.3.0-www-classic-aafdf38d",
1723817240
rendererPackageName: "react-dom"
1723917241
};
1724017242
var internals$jscomp$inline_2176 = {
@@ -17264,7 +17266,7 @@ var internals$jscomp$inline_2176 = {
1726417266
scheduleRoot: null,
1726517267
setRefreshHandler: null,
1726617268
getCurrentFiber: null,
17267-
reconcilerVersion: "18.3.0-www-classic-28494f4a"
17269+
reconcilerVersion: "18.3.0-www-classic-aafdf38d"
1726817270
};
1726917271
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1727017272
var hook$jscomp$inline_2177 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17595,4 +17597,4 @@ exports.useFormState = function (action, initialState, permalink) {
1759517597
exports.useFormStatus = function () {
1759617598
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1759717599
};
17598-
exports.version = "18.3.0-www-classic-28494f4a";
17600+
exports.version = "18.3.0-www-classic-aafdf38d";

0 commit comments

Comments
 (0)
⚡