Skip to content

Commit 970a34b

Browse files
existentialismgaearon
existentialism
authored and
gaearon
committed
Bump babel-eslint and remove flow supressions (#13727)
1 parent 13965b4 commit 970a34b

9 files changed

Lines changed: 69 additions & 85 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"babel-cli": "^6.6.5",
1010
"babel-code-frame": "^6.26.0",
1111
"babel-core": "^6.0.0",
12-
"babel-eslint": "^8.0.0",
12+
"babel-eslint": "^10.0.0",
1313
"babel-jest": "^23.0.1",
1414
"babel-plugin-check-es2015-constants": "^6.5.0",
1515
"babel-plugin-external-helpers": "^6.22.0",

‎packages/react-dom/src/client/ReactDOM.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ if (__DEV__) {
126126

127127
ReactControlledComponent.setRestoreImplementation(restoreControlledState);
128128

129-
/* eslint-disable no-use-before-define */
130129
type DOMContainer =
131130
| (Element & {
132131
_reactRootContainer: ?Root,
@@ -163,7 +162,6 @@ type Root = {
163162

164163
_internalRoot: FiberRoot,
165164
};
166-
/* eslint-enable no-use-before-define */
167165

168166
function ReactBatch(root: ReactRoot) {
169167
const expirationTime = DOMRenderer.computeUniqueAsyncExpiration();

‎packages/react-native-renderer/src/ReactFabricHostConfig.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ import UIManager from 'UIManager';
5050
// This means that they never overlap.
5151
let nextReactTag = 2;
5252

53-
/* eslint-disable no-use-before-define */
5453
type Node = Object;
5554
export type Type = string;
5655
export type Props = Object;
@@ -72,7 +71,6 @@ export type UpdatePayload = Object;
7271

7372
export type TimeoutHandle = TimeoutID;
7473
export type NoTimeout = -1;
75-
/* eslint-enable no-use-before-define */
7674

7775
// TODO: Remove this conditional once all changes have propagated.
7876
if (registerEventHandler) {

‎packages/react-noop-renderer/src/createReactNoop.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import type {ReactNodeList} from 'shared/ReactTypes';
2121
import * as ReactPortal from 'shared/ReactPortal';
2222
import expect from 'expect';
2323

24-
/* eslint-disable no-use-before-define */
2524
type Container = {rootID: string, children: Array<Instance | TextInstance>};
2625
type Props = {prop: any, hidden?: boolean, children?: mixed};
2726
type Instance = {|
@@ -31,7 +30,6 @@ type Instance = {|
3130
prop: any,
3231
|};
3332
type TextInstance = {|text: string, id: number|};
34-
/* eslint-enable no-use-before-define */
3533

3634
const NO_CONTEXT = {};
3735
const UPDATE_SIGNAL = {};

‎packages/react-reconciler/src/ReactFiberRoot.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {NoWork} from './ReactFiberExpirationTime';
1818
import {enableSchedulerTracing} from 'shared/ReactFeatureFlags';
1919
import {unstable_getThreadID} from 'scheduler/tracing';
2020

21-
/* eslint-disable no-use-before-define */
2221
// TODO: This should be lifted into the renderer.
2322
export type Batch = {
2423
_defer: boolean,
@@ -99,7 +98,6 @@ export type FiberRoot = {
9998
...BaseFiberRootProperties,
10099
...ProfilingOnlyFiberRootProperties,
101100
};
102-
/* eslint-enable no-use-before-define */
103101

104102
export function createFiberRoot(
105103
containerInfo: any,

‎packages/react-test-renderer/src/ReactTestHostConfig.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import warning from 'shared/warning';
1111
import * as TestRendererScheduling from './ReactTestRendererScheduling';
1212

13-
/* eslint-disable no-use-before-define */
1413
export type Type = string;
1514
export type Props = Object;
1615
export type Container = {|
@@ -36,7 +35,6 @@ export type UpdatePayload = Object;
3635
export type ChildSet = void; // Unused
3736
export type TimeoutHandle = TimeoutID;
3837
export type NoTimeout = -1;
39-
/* eslint-enable no-use-before-define */
4038

4139
export * from 'shared/HostConfigWithNoPersistence';
4240
export * from 'shared/HostConfigWithNoHydration';

‎packages/react-test-renderer/src/ReactTestRenderer.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import ReactVersion from 'shared/ReactVersion';
3737
import * as ReactTestHostConfig from './ReactTestHostConfig';
3838
import * as TestRendererScheduling from './ReactTestRendererScheduling';
3939

40-
/* eslint-disable no-use-before-define */
4140
type TestRendererOptions = {
4241
createNodeMock: (element: React$Element<any>) => any,
4342
unstable_isAsync: boolean,
@@ -58,7 +57,6 @@ type FindOptions = $Shape<{
5857
}>;
5958

6059
export type Predicate = (node: ReactTestInstance) => ?boolean;
61-
/* eslint-enable no-use-before-define */
6260

6361
const defaultTestOptions = {
6462
createNodeMock: function() {

‎packages/shared/ReactTypes.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,13 @@
77
* @flow
88
*/
99

10-
/* eslint-disable no-use-before-define */
1110
export type ReactNode =
1211
| React$Element<any>
1312
| ReactPortal
1413
| ReactText
1514
| ReactFragment
1615
| ReactProvider<any>
1716
| ReactConsumer<any>;
18-
/* eslint-enable no-use-before-define */
1917

2018
export type ReactEmpty = null | void | boolean;
2119

‎yarn.lock‎

Lines changed: 68 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -2,55 +2,47 @@
22
# yarn lockfile v1
33

44

5-
"@babel/code-frame@7.0.0-beta.44":
6-
version "7.0.0-beta.44"
7-
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.44.tgz#2a02643368de80916162be70865c97774f3adbd9"
5+
"@babel/code-frame@^7.0.0":
6+
version "7.0.0"
7+
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0.tgz#06e2ab19bdb535385559aabb5ba59729482800f8"
88
dependencies:
9-
"@babel/highlight" "7.0.0-beta.44"
9+
"@babel/highlight" "^7.0.0"
1010

1111
"@babel/code-frame@^7.0.0-beta.35":
1212
version "7.0.0-beta.49"
1313
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.49.tgz#becd805482734440c9d137e46d77340e64d7f51b"
1414
dependencies:
1515
"@babel/highlight" "7.0.0-beta.49"
1616

17-
"@babel/generator@7.0.0-beta.44":
18-
version "7.0.0-beta.44"
19-
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.0.0-beta.44.tgz#c7e67b9b5284afcf69b309b50d7d37f3e5033d42"
17+
"@babel/generator@^7.0.0":
18+
version "7.0.0"
19+
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.0.0.tgz#1efd58bffa951dc846449e58ce3a1d7f02d393aa"
2020
dependencies:
21-
"@babel/types" "7.0.0-beta.44"
21+
"@babel/types" "^7.0.0"
2222
jsesc "^2.5.1"
23-
lodash "^4.2.0"
23+
lodash "^4.17.10"
2424
source-map "^0.5.0"
2525
trim-right "^1.0.1"
2626

27-
"@babel/helper-function-name@7.0.0-beta.44":
28-
version "7.0.0-beta.44"
29-
resolved "https://registry.yarnpkg.com/@babel/helper-function-name/-/helper-function-name-7.0.0-beta.44.tgz#e18552aaae2231100a6e485e03854bc3532d44dd"
30-
dependencies:
31-
"@babel/helper-get-function-arity" "7.0.0-beta.44"
32-
"@babel/template" "7.0.0-beta.44"
33-
"@babel/types" "7.0.0-beta.44"
34-
35-
"@babel/helper-get-function-arity@7.0.0-beta.44":
36-
version "7.0.0-beta.44"
37-
resolved "https://registry.yarnpkg.com/@babel/helper-get-function-arity/-/helper-get-function-arity-7.0.0-beta.44.tgz#d03ca6dd2b9f7b0b1e6b32c56c72836140db3a15"
27+
"@babel/helper-function-name@^7.1.0":
28+
version "7.1.0"
29+
resolved "https://registry.yarnpkg.com/@babel/helper-function-name/-/helper-function-name-7.1.0.tgz#a0ceb01685f73355d4360c1247f582bfafc8ff53"
3830
dependencies:
39-
"@babel/types" "7.0.0-beta.44"
31+
"@babel/helper-get-function-arity" "^7.0.0"
32+
"@babel/template" "^7.1.0"
33+
"@babel/types" "^7.0.0"
4034

41-
"@babel/helper-split-export-declaration@7.0.0-beta.44":
42-
version "7.0.0-beta.44"
43-
resolved "https://registry.yarnpkg.com/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.0.0-beta.44.tgz#c0b351735e0fbcb3822c8ad8db4e583b05ebd9dc"
35+
"@babel/helper-get-function-arity@^7.0.0":
36+
version "7.0.0"
37+
resolved "https://registry.yarnpkg.com/@babel/helper-get-function-arity/-/helper-get-function-arity-7.0.0.tgz#83572d4320e2a4657263734113c42868b64e49c3"
4438
dependencies:
45-
"@babel/types" "7.0.0-beta.44"
39+
"@babel/types" "^7.0.0"
4640

47-
"@babel/highlight@7.0.0-beta.44":
48-
version "7.0.0-beta.44"
49-
resolved "https://registry.yarnpkg.com/@babel/highlight/-/highlight-7.0.0-beta.44.tgz#18c94ce543916a80553edcdcf681890b200747d5"
41+
"@babel/helper-split-export-declaration@^7.0.0":
42+
version "7.0.0"
43+
resolved "https://registry.yarnpkg.com/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.0.0.tgz#3aae285c0311c2ab095d997b8c9a94cad547d813"
5044
dependencies:
51-
chalk "^2.0.0"
52-
esutils "^2.0.2"
53-
js-tokens "^3.0.0"
45+
"@babel/types" "^7.0.0"
5446

5547
"@babel/highlight@7.0.0-beta.49":
5648
version "7.0.0-beta.49"
@@ -60,36 +52,46 @@
6052
esutils "^2.0.2"
6153
js-tokens "^3.0.0"
6254

63-
"@babel/template@7.0.0-beta.44":
64-
version "7.0.0-beta.44"
65-
resolved "https://registry.yarnpkg.com/@babel/template/-/template-7.0.0-beta.44.tgz#f8832f4fdcee5d59bf515e595fc5106c529b394f"
66-
dependencies:
67-
"@babel/code-frame" "7.0.0-beta.44"
68-
"@babel/types" "7.0.0-beta.44"
69-
babylon "7.0.0-beta.44"
70-
lodash "^4.2.0"
71-
72-
"@babel/traverse@7.0.0-beta.44":
73-
version "7.0.0-beta.44"
74-
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.0.0-beta.44.tgz#a970a2c45477ad18017e2e465a0606feee0d2966"
55+
"@babel/highlight@^7.0.0":
56+
version "7.0.0"
57+
resolved "https://registry.yarnpkg.com/@babel/highlight/-/highlight-7.0.0.tgz#f710c38c8d458e6dd9a201afb637fcb781ce99e4"
7558
dependencies:
76-
"@babel/code-frame" "7.0.0-beta.44"
77-
"@babel/generator" "7.0.0-beta.44"
78-
"@babel/helper-function-name" "7.0.0-beta.44"
79-
"@babel/helper-split-export-declaration" "7.0.0-beta.44"
80-
"@babel/types" "7.0.0-beta.44"
81-
babylon "7.0.0-beta.44"
59+
chalk "^2.0.0"
60+
esutils "^2.0.2"
61+
js-tokens "^4.0.0"
62+
63+
"@babel/parser@^7.0.0", "@babel/parser@^7.1.0":
64+
version "7.1.0"
65+
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.1.0.tgz#a7cd42cb3c12aec52e24375189a47b39759b783e"
66+
67+
"@babel/template@^7.1.0":
68+
version "7.1.0"
69+
resolved "https://registry.yarnpkg.com/@babel/template/-/template-7.1.0.tgz#58cc9572e1bfe24fe1537fdf99d839d53e517e22"
70+
dependencies:
71+
"@babel/code-frame" "^7.0.0"
72+
"@babel/parser" "^7.1.0"
73+
"@babel/types" "^7.0.0"
74+
75+
"@babel/traverse@^7.0.0":
76+
version "7.1.0"
77+
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.1.0.tgz#503ec6669387efd182c3888c4eec07bcc45d91b2"
78+
dependencies:
79+
"@babel/code-frame" "^7.0.0"
80+
"@babel/generator" "^7.0.0"
81+
"@babel/helper-function-name" "^7.1.0"
82+
"@babel/helper-split-export-declaration" "^7.0.0"
83+
"@babel/parser" "^7.1.0"
84+
"@babel/types" "^7.0.0"
8285
debug "^3.1.0"
8386
globals "^11.1.0"
84-
invariant "^2.2.0"
85-
lodash "^4.2.0"
87+
lodash "^4.17.10"
8688

87-
"@babel/types@7.0.0-beta.44":
88-
version "7.0.0-beta.44"
89-
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.0.0-beta.44.tgz#6b1b164591f77dec0a0342aca995f2d046b3a757"
89+
"@babel/types@^7.0.0":
90+
version "7.0.0"
91+
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.0.0.tgz#6e191793d3c854d19c6749989e3bc55f0e962118"
9092
dependencies:
9193
esutils "^2.0.2"
92-
lodash "^4.2.0"
94+
lodash "^4.17.10"
9395
to-fast-properties "^2.0.0"
9496

9597
abab@^1.0.4:
@@ -451,15 +453,15 @@ babel-core@^6.7.2:
451453
slash "^1.0.0"
452454
source-map "^0.5.7"
453455

454-
babel-eslint@^8.0.0:
455-
version "8.2.3"
456-
resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-8.2.3.tgz#1a2e6681cc9bc4473c32899e59915e19cd6733cf"
456+
babel-eslint@^10.0.0:
457+
version "10.0.0"
458+
resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-10.0.0.tgz#0bb43e6b11a119bf3defbb1ee2521f42e2d413c9"
457459
dependencies:
458-
"@babel/code-frame" "7.0.0-beta.44"
459-
"@babel/traverse" "7.0.0-beta.44"
460-
"@babel/types" "7.0.0-beta.44"
461-
babylon "7.0.0-beta.44"
462-
eslint-scope "~3.7.1"
460+
"@babel/code-frame" "^7.0.0"
461+
"@babel/parser" "^7.0.0"
462+
"@babel/traverse" "^7.0.0"
463+
"@babel/types" "^7.0.0"
464+
eslint-scope "3.7.1"
463465
eslint-visitor-keys "^1.0.0"
464466

465467
babel-generator@^6.18.0, babel-generator@^6.26.0:
@@ -957,10 +959,6 @@ babylon@6.18.0, babylon@^6.18.0:
957959
version "6.18.0"
958960
resolved "https://registry.yarnpkg.com/babylon/-/babylon-6.18.0.tgz#af2f3b88fa6f5c1e4c634d1a0f8eac4f55b395e3"
959961

960-
babylon@7.0.0-beta.44:
961-
version "7.0.0-beta.44"
962-
resolved "https://registry.yarnpkg.com/babylon/-/babylon-7.0.0-beta.44.tgz#89159e15e6e30c5096e22d738d8c0af8a0e8ca1d"
963-
964962
balanced-match@^1.0.0:
965963
version "1.0.0"
966964
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-1.0.0.tgz#89b4d199ab2bee49de164ea02b89ce462d71b767"
@@ -1675,7 +1673,7 @@ eslint-plugin-react@^6.7.1:
16751673
jsx-ast-utils "^1.3.4"
16761674
object.assign "^4.0.4"
16771675

1678-
eslint-scope@^3.7.1, eslint-scope@~3.7.1:
1676+
eslint-scope@3.7.1, eslint-scope@^3.7.1:
16791677
version "3.7.1"
16801678
resolved "https://registry.yarnpkg.com/eslint-scope/-/eslint-scope-3.7.1.tgz#3d63c3edfda02e06e01a452ad88caacc7cdcb6e8"
16811679
dependencies:
@@ -2483,7 +2481,7 @@ inquirer@^3.0.6:
24832481
strip-ansi "^4.0.0"
24842482
through "^2.3.6"
24852483

2486-
invariant@^2.2.0, invariant@^2.2.2:
2484+
invariant@^2.2.2:
24872485
version "2.2.4"
24882486
resolved "https://registry.yarnpkg.com/invariant/-/invariant-2.2.4.tgz#610f3c92c9359ce1db616e538008d23ff35158e6"
24892487
dependencies:
@@ -3140,7 +3138,7 @@ js-tokens@^3.0.0, js-tokens@^3.0.2:
31403138
version "3.0.2"
31413139
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b"
31423140

3143-
"js-tokens@^3.0.0 || ^4.0.0":
3141+
"js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0:
31443142
version "4.0.0"
31453143
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"
31463144

0 commit comments

Comments
 (0)
⚡