Skip to content

Commit d5d10d1

Browse files
mmarkelovnhunzaker
authored andcommitted
Simplify imports in react reconciler (#13718)
* Simplify imports in ReactChildFiber * Import type first in ReactCurrentFiber * Simplify imports in ReactFiberBeginWork * Simplify imports in ReactFiberScheduler * Simplify import in ReactFiberTreeReflection * Simplify import in ReactFiberUnwindWork * Remove repeated import * Fix imports from ReactFiberExpirationTime * Master imports in ReactFiberBeginWork
1 parent cdbfa6b commit d5d10d1

6 files changed

Lines changed: 11 additions & 7 deletions

File tree

packages/react-reconciler/src/ReactChildFiber.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
import type {ReactElement} from 'shared/ReactElementType';
1111
import type {ReactPortal} from 'shared/ReactTypes';
12-
import type {Fiber} from 'react-reconciler/src/ReactFiber';
13-
import type {ExpirationTime} from 'react-reconciler/src/ReactFiberExpirationTime';
12+
import type {Fiber} from './ReactFiber';
13+
import type {ExpirationTime} from './ReactFiberExpirationTime';
1414

1515
import getComponentName from 'shared/getComponentName';
1616
import {Placement, Deletion} from 'shared/ReactSideEffectTags';

packages/react-reconciler/src/ReactCurrentFiber.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
* @flow
88
*/
99

10+
import type {Fiber} from './ReactFiber';
11+
1012
import ReactSharedInternals from 'shared/ReactSharedInternals';
1113
import {
1214
IndeterminateComponent,
@@ -21,8 +23,6 @@ import getComponentName from 'shared/getComponentName';
2123

2224
const ReactDebugCurrentFrame = ReactSharedInternals.ReactDebugCurrentFrame;
2325

24-
import type {Fiber} from './ReactFiber';
25-
2626
type LifeCyclePhase = 'render' | 'getChildContext';
2727

2828
function describeFiber(fiber: Fiber): string {

packages/react-reconciler/src/ReactFiberBeginWork.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import type {ReactProviderType, ReactContext} from 'shared/ReactTypes';
11-
import type {Fiber} from 'react-reconciler/src/ReactFiber';
11+
import type {Fiber} from './ReactFiber';
1212
import type {FiberRoot} from './ReactFiberRoot';
1313
import type {ExpirationTime} from './ReactFiberExpirationTime';
1414
import type {SuspenseState} from './ReactFiberSuspenseComponent';

packages/react-reconciler/src/ReactFiberScheduler.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ import {
7878
noTimeout,
7979
prepareForCommit,
8080
resetAfterCommit,
81+
scheduleTimeout,
82+
cancelTimeout,
83+
noTimeout,
8184
} from './ReactFiberHostConfig';
8285
import {
8386
markPendingPriorityLevel,

packages/react-reconciler/src/ReactFiberTreeReflection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @flow
88
*/
99

10-
import type {Fiber} from 'react-reconciler/src/ReactFiber';
10+
import type {Fiber} from './ReactFiber';
1111

1212
import invariant from 'shared/invariant';
1313
import warningWithoutStack from 'shared/warningWithoutStack';

packages/react-reconciler/src/ReactFiberUnwindWork.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,12 @@ import {
6161
isAlreadyFailedLegacyErrorBoundary,
6262
retrySuspendedRoot,
6363
} from './ReactFiberScheduler';
64-
import {NoWork, Sync} from './ReactFiberExpirationTime';
6564

6665
import invariant from 'shared/invariant';
6766
import maxSigned31BitInt from './maxSigned31BitInt';
6867
import {
68+
NoWork,
69+
Sync,
6970
expirationTimeToMs,
7071
LOW_PRIORITY_EXPIRATION,
7172
} from './ReactFiberExpirationTime';

0 commit comments

Comments
 (0)