Handle invalid URLs

Author: eps1lon

packages/react-devtools-extensions/src/main/fetchFileWithCaching.js

@@ -1,5 +1,6 @@
 /* global chrome */
 
+import {normalizeUrlIfValid} from 'react-devtools-shared/src/utils';
 import {__DEBUG__} from 'react-devtools-shared/src/constants';
 
 let debugIDCounter = 0;
@@ -116,7 +117,7 @@ async function fetchFileWithCaching(url: string): Promise<string> {
       chrome.devtools.inspectedWindow.getResources(r => resolve(r)),
     );
 
-    const normalizedReferenceURL = new URL(url).toString();
+    const normalizedReferenceURL = normalizeUrlIfValid(url);
     const resource = resources.find(r => r.url === normalizedReferenceURL);
 
     if (resource != null) {

packages/react-devtools-extensions/src/main/index.js

@@ -16,6 +16,7 @@ import {
   LOCAL_STORAGE_TRACE_UPDATES_ENABLED_KEY,
 } from 'react-devtools-shared/src/constants';
 import {logEvent} from 'react-devtools-shared/src/Logger';
+import {normalizeUrlIfValid} from 'react-devtools-shared/src/utils';
 
 import {
   setBrowserSelectionFromReact,
@@ -129,9 +130,7 @@ function createBridgeAndStore() {
 
     // We use 1-based line and column, Chrome expects them 0-based.
     chrome.devtools.panels.openResource(
-      // openResource needs normalized URLs.
-      // Using `URL` triggers path normalization.
-      new URL(sourceURL).toString(),
+      normalizeUrlIfValid(sourceURL),
       line - 1,
       column - 1,
     );

packages/react-devtools-shared/src/utils.js

@@ -996,6 +996,19 @@ export function backendToFrontendSerializedElementMapper(
   };
 }
 
+/**
+ * Should be used when treating url as a Chrome Resource URL.
+ */
+export function normalizeUrlIfValid(url: string): string {
+  try {
+    return new URL(url).toString();
+  } catch {
+    // Giving up if it's not a valid URL without basepath
+    // TODO: Chrome will use the basepath to create a Resource URL.
+    return url;
+  }
+}
+
 export function getIsReloadAndProfileSupported(): boolean {
   // Notify the frontend if the backend supports the Storage API (e.g. localStorage).
   // If not, features like reload-and-profile will not work correctly and must be disabled.