Fixes directory paths with slash at the end during "archive_bag".#36
Closed
sterlingbaldwin wants to merge 2 commits into
Closed
Fixes directory paths with slash at the end during "archive_bag".#36sterlingbaldwin wants to merge 2 commits into
sterlingbaldwin wants to merge 2 commits into
Conversation
Pull Request Test Coverage Report for Build 260
💛 - Coveralls |
Collaborator
|
Thanks for reporting this. I fixed it a bit differently in b126a96, but the result should be the same without having to add an additional unit test. |
Author
|
Ah, I didnt see it had been fixed already. Your method is definitely more "pythonic." |
Collaborator
I hadn't fixed it prior to you reporting the issue, so definite thanks and credit go to you for catching it! |
Collaborator
|
Fixed in b126a96. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user passes something like "/Users/me/some_directory/" then what happens is that the tar ends up as "/Users/me/some_directory/.tar" instead of ""/Users/me/some_directory.tar" like it should be. This PR is just two lines that remove the trailing os.sep character from the bag_path so that the tar ends up where it should be.