Skip to content

Fixes directory paths with slash at the end during "archive_bag".#36

Closed
sterlingbaldwin wants to merge 2 commits into
fair-research:masterfrom
sterlingbaldwin:master
Closed

Fixes directory paths with slash at the end during "archive_bag".#36
sterlingbaldwin wants to merge 2 commits into
fair-research:masterfrom
sterlingbaldwin:master

Conversation

@sterlingbaldwin
Copy link
Copy Markdown

If the user passes something like "/Users/me/some_directory/" then what happens is that the tar ends up as "/Users/me/some_directory/.tar" instead of ""/Users/me/some_directory.tar" like it should be. This PR is just two lines that remove the trailing os.sep character from the bag_path so that the tar ends up where it should be.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 8, 2019

Pull Request Test Coverage Report for Build 260

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 93.156%

Totals Coverage Status
Change from base Build 258: 0.009%
Covered Lines: 6003
Relevant Lines: 6444

💛 - Coveralls

mikedarcy added a commit that referenced this pull request Oct 9, 2019
@mikedarcy
Copy link
Copy Markdown
Collaborator

Thanks for reporting this. I fixed it a bit differently in b126a96, but the result should be the same without having to add an additional unit test.

@sterlingbaldwin
Copy link
Copy Markdown
Author

Ah, I didnt see it had been fixed already. Your method is definitely more "pythonic."

@mikedarcy
Copy link
Copy Markdown
Collaborator

Ah, I didnt see it had been fixed already. Your method is definitely more "pythonic."

I hadn't fixed it prior to you reporting the issue, so definite thanks and credit go to you for catching it!

@mikedarcy
Copy link
Copy Markdown
Collaborator

Fixed in b126a96.

@mikedarcy mikedarcy closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants