Add disableObjectify option to use normal strings as id#171
Merged
daffl merged 1 commit intofeathersjs:masterfrom Nov 21, 2019
Merged
Add disableObjectify option to use normal strings as id#171daffl merged 1 commit intofeathersjs:masterfrom
daffl merged 1 commit intofeathersjs:masterfrom
Conversation
Member
|
I think that makes sense, thank you for the pull request @ydeshayes. Released as v6.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Summary
This PR is an attempt to resolve feathersjs/feathers#1660.
The problem is that the objectify of _id need to be done in the adapter IMHO because without that it break a lot of things for MongoDB and the third party libs.
This add a disableObjectify option that can be use in the service that will disable the objectify of the
id field. If user want to use strings which is not the normal MongoDB behavior, you can add this option.Thanks