Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Commit 47eb29a

Browse files
greenkeeper[bot]daffl
authored andcommitted
Update @feathersjs/transport-commons to the latest version 🚀 (#77)
* fix(package): update @feathersjs/transport-commons to version 4.0.0 * Account for connection being passed
1 parent 58098cf commit 47eb29a

4 files changed

Lines changed: 9 additions & 8 deletions

File tree

lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const commons = require('@feathersjs/transport-commons');
1+
const { socket: commons } = require('@feathersjs/transport-commons');
22
const makeDebug = require('debug');
33
const Proto = require('uberproto');
44
const Primus = require('primus');

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"./lib/index": "./lib/client"
5050
},
5151
"dependencies": {
52-
"@feathersjs/transport-commons": "^3.2.0",
52+
"@feathersjs/transport-commons": "^4.0.0",
5353
"debug": "^3.1.0",
5454
"primus": "^7.0.0",
5555
"primus-emitter": "^3.1.1"

test/index.test.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,21 +134,22 @@ describe('@feathersjs/primus', () => {
134134
};
135135

136136
service.find = function (params) {
137-
assert.deepEqual(_.omit(params, 'query', 'route'), options.socketParams,
137+
assert.deepEqual(_.omit(params, 'query', 'route', 'connection'), options.socketParams,
138138
'Handshake parameters passed on proper position');
139139

140140
return old.find.apply(this, arguments);
141141
};
142142

143143
service.create = function (data, params) {
144-
assert.deepEqual(_.omit(params, 'query', 'route'), options.socketParams,
144+
assert.deepEqual(_.omit(params, 'query', 'route', 'connection'), options.socketParams,
145145
'Passed handshake parameters');
146146

147147
return old.create.apply(this, arguments);
148148
};
149149

150150
service.update = function (id, data, params) {
151151
assert.deepEqual(params, _.extend({
152+
connection: options.socketParams,
152153
route: {},
153154
query: {
154155
test: 'param'
@@ -176,7 +177,7 @@ describe('@feathersjs/primus', () => {
176177
};
177178

178179
service.find = function (params) {
179-
assert.deepEqual(_.omit(params, 'query', 'route'), options.socketParams,
180+
assert.deepEqual(_.omit(params, 'query', 'route', 'connection'), options.socketParams,
180181
'Handshake parameters passed on proper position');
181182

182183
return old.find.apply(this, arguments);

0 commit comments

Comments
 (0)