diff --git a/lib/index.js b/lib/index.js index 2696cea..66cd8bb 100644 --- a/lib/index.js +++ b/lib/index.js @@ -1,4 +1,4 @@ -const commons = require('@feathersjs/transport-commons'); +const { socket: commons } = require('@feathersjs/transport-commons'); const makeDebug = require('debug'); const Proto = require('uberproto'); const Primus = require('primus'); diff --git a/package-lock.json b/package-lock.json index b778ff1..16d6385 100644 --- a/package-lock.json +++ b/package-lock.json @@ -43,9 +43,9 @@ } }, "@feathersjs/transport-commons": { - "version": "3.2.0", - "resolved": "https://registry.npmjs.org/@feathersjs/transport-commons/-/transport-commons-3.2.0.tgz", - "integrity": "sha512-mUx/QlbNo9H9B6d3PqrMuHzZeu8Kh04ml/aLR1OnY9QLU9eafKrDQTNztGg7GKL4dW143WR2qwlx+y9UspavNg==", + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/@feathersjs/transport-commons/-/transport-commons-4.0.0.tgz", + "integrity": "sha512-O+kuJWpdao0Lw5Pg/65eOuMIlxu+aP9bnK9jNlxfwVdqCxw4eX3Jh8WS0WmQpfZYILk5oyhP/IUdHgSqcjaXgw==", "requires": { "@feathersjs/commons": "1.4.0", "@feathersjs/errors": "3.2.2", diff --git a/package.json b/package.json index 8c898f4..ef6f7aa 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "./lib/index": "./lib/client" }, "dependencies": { - "@feathersjs/transport-commons": "^3.2.0", + "@feathersjs/transport-commons": "^4.0.0", "debug": "^3.1.0", "primus": "^7.0.0", "primus-emitter": "^3.1.1" diff --git a/test/index.test.js b/test/index.test.js index 80f457c..2a6486c 100644 --- a/test/index.test.js +++ b/test/index.test.js @@ -134,14 +134,14 @@ describe('@feathersjs/primus', () => { }; service.find = function (params) { - assert.deepEqual(_.omit(params, 'query', 'route'), options.socketParams, + assert.deepEqual(_.omit(params, 'query', 'route', 'connection'), options.socketParams, 'Handshake parameters passed on proper position'); return old.find.apply(this, arguments); }; service.create = function (data, params) { - assert.deepEqual(_.omit(params, 'query', 'route'), options.socketParams, + assert.deepEqual(_.omit(params, 'query', 'route', 'connection'), options.socketParams, 'Passed handshake parameters'); return old.create.apply(this, arguments); @@ -149,6 +149,7 @@ describe('@feathersjs/primus', () => { service.update = function (id, data, params) { assert.deepEqual(params, _.extend({ + connection: options.socketParams, route: {}, query: { test: 'param' @@ -176,7 +177,7 @@ describe('@feathersjs/primus', () => { }; service.find = function (params) { - assert.deepEqual(_.omit(params, 'query', 'route'), options.socketParams, + assert.deepEqual(_.omit(params, 'query', 'route', 'connection'), options.socketParams, 'Handshake parameters passed on proper position'); return old.find.apply(this, arguments);