Add Did.from negative tests

Author: filip26

src/main/java/com/apicatalog/did/Did.java

@@ -134,7 +134,9 @@ protected static Did from(final Object uri, final String method, final String sp
 
         // check method specific id
         if (specificId == null
-                || specificId.length() == 0) {
+                || specificId.length() == 0
+                // FIXME does not validate pct-encoded correctly
+                || !specificId.codePoints().allMatch(ID_CHAR.or(ch -> ch == ':' || ch == '%'))) {
             throw new IllegalArgumentException("The URI [" + uri + "] is not valid DID, method specific id [" + specificId + "] is blank.");
         }
 

src/test/java/com/apicatalog/did/DidTest.java

@@ -4,6 +4,7 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import java.net.URI;
 import java.util.Arrays;
@@ -31,6 +32,17 @@ void fromString(String uri, String method, String specificId) {
         assertEquals(specificId, did.getMethodSpecificId());
     }
 
+    @DisplayName("!from(String)")
+    @ParameterizedTest()
+    @MethodSource({ "negativeVectors" })
+    void fromStringNegative(String uri) {
+        try {
+            Did.from(uri);
+            fail();
+        } catch (IllegalArgumentException e) {
+            /* expected */ }
+    }
+
     @DisplayName("from(URI)")
     @ParameterizedTest(name = "{0}")
     @MethodSource({ "validVectors" })
@@ -43,6 +55,20 @@ void fromUri(String input, String method, String specificId) {
         assertEquals(specificId, did.getMethodSpecificId());
     }
 
+    @DisplayName("!from(URI)")
+    @ParameterizedTest()
+    @MethodSource({ "negativeVectors" })
+    void fromUriNegative(String uri) {
+
+        final URI tmp = URI.create(uri);
+
+        try {
+            Did.from(tmp);
+            fail();
+        } catch (IllegalArgumentException e) {
+            /* expected */ }
+    }
+
     @DisplayName("toUri()")
     @ParameterizedTest(name = "{0}")
     @MethodSource({ "validVectors" })