Skip to content

Commit 3b6ebd5

Browse files
authored
Merge pull request #1251 from finos/fix-transaction-result-schema
Correcting a syntax error in the TransactionResult Schema
2 parents 120a0e5 + fff4b0e commit 3b6ebd5

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
2424

2525
### Fixed
2626

27-
* Corrected inconsistent camel-casing of the `fdc3.timeRange` context type which appeared as `fdc3.timerange` in a number of places. ([#1240][https://github.com/finos/FDC3/pull/1240])
27+
* Corrected inconsistent camel-casing of the `fdc3.timeRange` context type which appeared as `fdc3.timerange` in a number of places. ([#1240](https://github.com/finos/FDC3/pull/1240))
28+
* Corrected an error in the `fdc3.TransactionResult` schema which resulted in the `message` property being omitted from the generated TypeScript types for it. ([#1251](https://github.com/finos/FDC3/pull/1251))
2829

2930
## [FDC3 Standard 2.1](https://github.com/finos/FDC3/compare/v2.0..v2.1) - 2023-09-13
3031

schemas/context/transactionresult.schema.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
"$ref": "context.schema.json#",
2727
"title": "Transaction Result Context",
2828
"description": "A context object returned by the transaction, possibly with updated data."
29+
},
30+
"message": {
31+
"type": "string",
32+
"title": "Transaction Message",
33+
"description": "A human readable message describing the outcome of the transaction."
2934
}
3035
},
31-
"message": {
32-
"type": "string",
33-
"title": "Transaction Message",
34-
"description": "A human readable message describing the outcome of the transaction."
35-
},
3636
"required": [
3737
"type",
3838
"status"

src/context/ContextTypes.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1938,6 +1938,10 @@ export interface TransactionResult {
19381938
* A context object returned by the transaction, possibly with updated data.
19391939
*/
19401940
context?: ContextElement;
1941+
/**
1942+
* A human readable message describing the outcome of the transaction.
1943+
*/
1944+
message?: string;
19411945
/**
19421946
* The status of the transaction being reported.
19431947
*/
@@ -2766,6 +2770,7 @@ const typeMap: any = {
27662770
], "any"),
27672771
"TransactionResult": o([
27682772
{ json: "context", js: "context", typ: u(undefined, r("ContextElement")) },
2773+
{ json: "message", js: "message", typ: u(undefined, "") },
27692774
{ json: "status", js: "status", typ: r("TransactionStatus") },
27702775
{ json: "type", js: "type", typ: r("TransactionResultType") },
27712776
{ json: "id", js: "id", typ: u(undefined, m("any")) },

0 commit comments

Comments
 (0)