Skip to content

Commit cb63061

Browse files
julianna-ciqkriswest
authored andcommitted
Fix builds
1 parent f87361c commit cb63061

7 files changed

Lines changed: 36 additions & 23 deletions

File tree

packages/fdc3-agent-proxy/src/apps/DefaultAppSupport.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ export class DefaultAppSupport implements AppSupport {
8888
instanceId: app.instanceId,
8989
},
9090
context,
91+
metadata: metadata ?? {},
9192
},
92-
metadata,
9393
meta: this.messaging.createMeta(),
9494
};
9595

@@ -128,7 +128,6 @@ export class DefaultAppSupport implements AppSupport {
128128
provider: 'unknown',
129129
appMetadata: { appId: 'unknown', instanceId: 'unknown' },
130130
optionalFeatures: {
131-
OriginatingAppMetadata: false,
132131
UserChannelMembershipAPIs: false,
133132
DesktopAgentBridging: false,
134133
},

packages/fdc3-agent-proxy/src/channels/DefaultChannel.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
import { ContextHandler, DisplayMetadata, Listener, Channel, EventHandler } from '@finos/fdc3-standard';
1+
import {
2+
ContextHandler,
3+
DisplayMetadata,
4+
Listener,
5+
Channel,
6+
EventHandler,
7+
AppProvidableContextMetadata,
8+
} from '@finos/fdc3-standard';
29
import { Context } from '@finos/fdc3-context';
310
import { Messaging } from '../Messaging.js';
411
import { DefaultContextListener } from '../listeners/DefaultContextListener.js';
@@ -39,12 +46,13 @@ export class DefaultChannel implements Channel {
3946
this.addContextListener = this.addContextListener.bind(this);
4047
}
4148

42-
async broadcast(context: Context): Promise<void> {
49+
async broadcast(context: Context, metadata?: AppProvidableContextMetadata): Promise<void> {
4350
const request: BroadcastRequest = {
4451
meta: this.messaging.createMeta(),
4552
payload: {
4653
channelId: this.id,
4754
context,
55+
metadata: metadata ?? {},
4856
},
4957
type: 'broadcastRequest',
5058
};

packages/fdc3-agent-proxy/src/intents/DefaultIntentSupport.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class DefaultIntentSupport implements IntentSupport {
135135
async raiseIntent(
136136
intent: string,
137137
context: Context,
138-
app: AppIdentifier,
138+
app?: AppIdentifier | null,
139139
metadata?: AppProvidableContextMetadata
140140
): Promise<IntentResolution> {
141141
const meta = this.messaging.createMeta();
@@ -144,7 +144,7 @@ export class DefaultIntentSupport implements IntentSupport {
144144
payload: {
145145
intent,
146146
context,
147-
app,
147+
app: app || undefined,
148148
metadata: {
149149
traceId: metadata?.traceId ?? v4(),
150150
},
@@ -195,9 +195,9 @@ export class DefaultIntentSupport implements IntentSupport {
195195
payload: {
196196
context,
197197
app,
198-
},
199-
metadata: {
200-
traceId: metadata?.traceId ?? v4(),
198+
metadata: {
199+
traceId: metadata?.traceId ?? v4(),
200+
},
201201
},
202202
meta,
203203
};

packages/fdc3-agent-proxy/src/listeners/DefaultContextListener.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ export class DefaultContextListener
4646

4747
action(m: BroadcastEvent): void {
4848
const metadata: DesktopAgentProvidableContextMetadata = {
49-
source: m.payload.originatingApp,
50-
timestamp: m.meta.timestamp,
51-
traceId: m.metadata?.traceId,
49+
source: m.payload.metadata?.source,
50+
timestamp: m.payload.metadata?.timestamp ?? m.meta.timestamp,
51+
traceId: m.payload.metadata?.traceId,
5252
};
5353
this.handler(m.payload.context, metadata);
5454
}

packages/fdc3-agent-proxy/src/listeners/DefaultIntentListener.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ export class DefaultIntentListener extends AbstractListener<IntentHandler, AddIn
3434

3535
action(m: IntentEvent): void {
3636
const done = this.handler(m.payload.context, {
37-
source: m.payload.originatingApp as AppIdentifier,
38-
timestamp: m.meta.timestamp,
39-
traceId: m.metadata?.traceId ?? v4(),
37+
source: m.payload.metadata?.source as AppIdentifier,
38+
timestamp: m.payload.metadata?.timestamp ?? m.meta.timestamp,
39+
traceId: m.payload.metadata?.traceId ?? v4(),
4040
});
4141

4242
this.handleIntentResult(done, m);
@@ -54,7 +54,6 @@ export class DefaultIntentListener extends AbstractListener<IntentHandler, AddIn
5454
intentEventUuid: m.meta.eventUuid,
5555
raiseIntentRequestUuid: m.payload.raiseIntentRequestUuid,
5656
},
57-
metadata: m.metadata,
5857
};
5958

6059
return out;

toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/IntentHandler.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,13 @@ async function forwardRequest(
5353
payload: {
5454
context: arg0.context,
5555
intent: arg0.intent,
56-
originatingApp: {
57-
appId: arg0.from.appId,
58-
instanceId: arg0.from.instanceId,
56+
metadata: {
57+
source: {
58+
appId: arg0.from.appId,
59+
instanceId: arg0.from.instanceId,
60+
},
61+
timestamp: new Date(),
62+
traceId: sc.createUUID(),
5963
},
6064
raiseIntentRequestUuid: arg0.requestUuid,
6165
},

toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/OpenHandler.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,13 @@ export class OpenHandler implements MessageHandler {
169169
payload: {
170170
channelId: null,
171171
context: pendingOpen.context,
172-
originatingApp: {
173-
appId: pendingOpen.source.appId,
174-
instanceId: pendingOpen.source.instanceId,
172+
metadata: {
173+
source: {
174+
appId: pendingOpen.source.appId,
175+
instanceId: pendingOpen.source.instanceId,
176+
},
177+
timestamp: new Date(),
178+
traceId: sc.createUUID(),
175179
},
176180
},
177181
};
@@ -278,7 +282,6 @@ export class OpenHandler implements MessageHandler {
278282
fdc3Version: sc.fdc3Version(),
279283
optionalFeatures: {
280284
DesktopAgentBridging: false,
281-
OriginatingAppMetadata: true,
282285
UserChannelMembershipAPIs: true,
283286
},
284287
appMetadata: appMetadata,

0 commit comments

Comments
 (0)