Skip to content

Commit d837395

Browse files
committed
chore: address reviewer feedback
- Remove '// trigger' comment from webpack.config.js - Pin codeql-action steps to commit SHA - Simplify cve-scanning to use node 22 only (no matrix)
1 parent f408c80 commit d837395

3 files changed

Lines changed: 5 additions & 9 deletions

File tree

.github/workflows/codeql.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ jobs:
3131
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
3232

3333
- name: Initialize CodeQL
34-
uses: github/codeql-action/init@v3
34+
uses: github/codeql-action/init@3b1a19a80ab047f35cbb237b5bd9bdc1e14f166c # v3
3535
with:
3636
languages: ${{ matrix.language }}
3737

3838
- name: Autobuild
39-
uses: github/codeql-action/autobuild@v3
39+
uses: github/codeql-action/autobuild@3b1a19a80ab047f35cbb237b5bd9bdc1e14f166c # v3
4040

4141
- name: Perform CodeQL Analysis
42-
uses: github/codeql-action/analyze@v3
42+
uses: github/codeql-action/analyze@3b1a19a80ab047f35cbb237b5bd9bdc1e14f166c # v3
4343
with:
4444
category: "/language:${{matrix.language}}"

.github/workflows/cve-scanning.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,12 @@ permissions:
2525
jobs:
2626
build:
2727
runs-on: ubuntu-latest
28-
strategy:
29-
matrix:
30-
node-version: [22, 24, 25]
3128
steps:
3229
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
33-
- name: Use Node.js ${{ matrix.node-version }}
30+
- name: Use Node.js 22
3431
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
3532
with:
36-
node-version: ${{ matrix.node-version }}
33+
node-version: 22
3734

3835
- run: npm install
3936

toolbox/fdc3-conformance/webpack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,3 @@ module.exports = () => {
6868
}
6969
return config;
7070
};
71-
// trigger

0 commit comments

Comments
 (0)