Refactors ContextTypes to union type instead of enum (#1138)

Author: andreifloricel

src/context/ContextType.ts

@@ -2,26 +2,28 @@
  * SPDX-License-Identifier: Apache-2.0
  * Copyright FINOS FDC3 contributors - see NOTICE file
  */
-export enum ContextTypes {
-  Chart = 'fdc3.chart',
-  ChatInitSettings = 'fdc3.chat.initSettings',
-  ChatRoom = 'fdc3.chat.room',
-  Contact = 'fdc3.contact',
-  ContactList = 'fdc3.contactList',
-  Country = 'fdc3.country',
-  Currency = 'fdc3.currency',
-  Email = 'fdc3.email',
-  Instrument = 'fdc3.instrument',
-  InstrumentList = 'fdc3.instrumentList',
-  Interaction = 'fdc3.interaction',
-  Nothing = 'fdc3.nothing',
-  Organization = 'fdc3.organization',
-  Portfolio = 'fdc3.portfolio',
-  Position = 'fdc3.position',
-  ChatSearchCriteria = 'fdc3.chat.searchCriteria',
-  TimeRange = 'fdc3.timerange',
-  TransactionResult = 'fdc3.transactionResult',
-  Valuation = 'fdc3.valuation',
-}
+export type StandardContextType =
+  | 'fdc3.action'
+  | 'fdc3.chart'
+  | 'fdc3.chat.initSettings'
+  | 'fdc3.chat.message'
+  | 'fdc3.chat.room'
+  | 'fdc3.chat.searchCriteria'
+  | 'fdc3.contact'
+  | 'fdc3.contactList'
+  | 'fdc3.country'
+  | 'fdc3.currency'
+  | 'fdc3.email'
+  | 'fdc3.instrument'
+  | 'fdc3.instrumentList'
+  | 'fdc3.interaction'
+  | 'fdc3.message'
+  | 'fdc3.organization'
+  | 'fdc3.portfolio'
+  | 'fdc3.position'
+  | 'fdc3.nothing'
+  | 'fdc3.timerange'
+  | 'fdc3.transactionResult'
+  | 'fdc3.valuation';
 
-export type ContextType = ContextTypes | string;
+export type ContextType = StandardContextType | string;

test/Methods.test.ts

@@ -5,7 +5,6 @@ import {
   broadcast,
   compareVersionNumbers,
   ContextHandler,
-  ContextTypes,
   DesktopAgent,
   fdc3Ready,
   findIntent,
@@ -33,7 +32,7 @@ const TimeoutError = new Error('Timed out waiting for `fdc3Ready` event.');
 const UnexpectedError = new Error('`fdc3Ready` event fired, but `window.fdc3` not set to DesktopAgent.');
 
 const ContactContext = {
-  type: ContextTypes.Contact,
+  type: 'fdc3.contact',
   id: { email: 'test@example.com' },
 };
 
@@ -163,10 +162,10 @@ describe('test ES6 module', () => {
     test('findIntent should delegate to window.fdc3.findIntent (with additional output type argument)', async () => {
       const intent = 'ViewChart';
 
-      await findIntent(intent, ContactContext, ContextTypes.Contact);
+      await findIntent(intent, ContactContext, 'fdc3.contact');
 
       expect(window.fdc3.findIntent).toHaveBeenCalledTimes(1);
-      expect(window.fdc3.findIntent).toHaveBeenLastCalledWith(intent, ContactContext, ContextTypes.Contact);
+      expect(window.fdc3.findIntent).toHaveBeenLastCalledWith(intent, ContactContext, 'fdc3.contact');
     });
 
     test('findIntentsByContext should delegate to window.fdc3.findIntentsByContext', async () => {
@@ -177,10 +176,10 @@ describe('test ES6 module', () => {
     });
 
     test('findIntentsByContext should delegate to window.fdc3.findIntentsByContext (with additional output type argument)', async () => {
-      await findIntentsByContext(ContactContext, ContextTypes.Contact);
+      await findIntentsByContext(ContactContext, 'fdc3.contact');
 
       expect(window.fdc3.findIntentsByContext).toHaveBeenCalledTimes(1);
-      expect(window.fdc3.findIntentsByContext).toHaveBeenLastCalledWith(ContactContext, ContextTypes.Contact);
+      expect(window.fdc3.findIntentsByContext).toHaveBeenLastCalledWith(ContactContext, 'fdc3.contact');
     });
 
     test('broadcast should delegate to window.fdc3.broadcast', async () => {