Skip to content

Commit 2452f10

Browse files
authored
Merge pull request #1389 from finos/1388-reduce-db-bloat
fix: reduce DB and log bloat by not logging writePack content
2 parents c206394 + bf516a9 commit 2452f10

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

src/proxy/processors/push-action/writePack.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ const exec = async (req: any, action: Action) => {
2727
];
2828
action.newIdxFiles = newIdxFiles;
2929
step.log(`new idx files: ${newIdxFiles}`);
30-
31-
step.setContent(content);
3230
} catch (e: any) {
3331
step.setError(e.toString('utf-8'));
3432
throw e;

test/processors/writePack.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ describe('writePack', () => {
1212
let readdirSyncMock: any;
1313
let spawnSyncMock: any;
1414
let stepLogSpy: any;
15-
let stepSetContentSpy: any;
1615
let stepSetErrorSpy: any;
1716

1817
beforeEach(async () => {
@@ -25,7 +24,6 @@ describe('writePack', () => {
2524
.mockReturnValueOnce(['old1.idx', 'new1.idx'] as any);
2625

2726
stepLogSpy = vi.spyOn(Step.prototype, 'log');
28-
stepSetContentSpy = vi.spyOn(Step.prototype, 'setContent');
2927
stepSetErrorSpy = vi.spyOn(Step.prototype, 'setError');
3028

3129
const writePack = await import('../../src/proxy/processors/push-action/writePack');
@@ -81,7 +79,6 @@ describe('writePack', () => {
8179
);
8280

8381
expect(stepLogSpy).toHaveBeenCalledWith('new idx files: new1.idx');
84-
expect(stepSetContentSpy).toHaveBeenCalledWith(dummySpawnOutput);
8582
expect(result.steps).toHaveLength(1);
8683
expect(result.steps[0].error).toBe(false);
8784
expect(result.newIdxFiles).toEqual(['new1.idx']);

0 commit comments

Comments
 (0)