fix(cypress): remove TS syntax from .js files and fix git credentials

- Remove TypeScript type annotations from .cy.js files (Babel doesn't support them)
- Use git server credentials (testuser/user123) for cy.createPush() calls
  instead of app user credentials which don't exist on the git server

Author: dcoric

.gitignore

@@ -276,3 +276,4 @@ website/.docusaurus
 
 # Generated from testing
 /test/fixtures/test-package/package-lock.json
+cypress/screenshots/

cypress/e2e/push-details.cy.js

@@ -20,6 +20,9 @@ describe('Push Details — Tabs & Content Rendering', () => {
     password: 'testuser123',
     email: 'pushdetails_testuser@example.com',
     gitAccount: 'pushdetails_testuser',
+    // Git credentials must match a user on the git server for cy.createPush() to work
+    gitUsername: 'testuser',
+    gitPassword: 'user123',
   };
 
   const approverUser = {
@@ -61,7 +64,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.1 Pending push shows Pending status ---
   it('1.1 — Pending push shows Pending status with action buttons', function () {
     const suffix = `pending-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login('admin', 'admin');
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -78,7 +81,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.2 Card body renders info fields with correct links ---
   it('1.2 — Card body renders Timestamp, Remote Head, Commit SHA, Repository, Branch', function () {
     const suffix = `info-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login('admin', 'admin');
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -99,7 +102,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.3 Commits tab renders commit data table ---
   it('1.3 — Commits tab renders commit data table with correct columns', function () {
     const suffix = `commits-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login('admin', 'admin');
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -117,7 +120,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.4 Changes tab renders diff content ---
   it('1.4 — Changes tab renders diff content via diff2html', function () {
     const suffix = `changes-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login('admin', 'admin');
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -133,7 +136,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.5 Steps tab renders steps timeline with summary ---
   it('1.5 — Steps tab renders steps timeline with summary chips', function () {
     const suffix = `steps-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login('admin', 'admin');
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -155,7 +158,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.6 Steps accordions expand and show content/logs ---
   it('1.6 — Steps accordions expand and show content/logs', function () {
     const suffix = `accordion-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login('admin', 'admin');
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -179,7 +182,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.7 Rejected push shows rejection info with reason ---
   it('1.7 — Rejected push shows rejection info with reason', function () {
     const suffix = `reject-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login(approverUser.username, approverUser.password);
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -211,7 +214,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.8 Approved push shows attestation info ---
   it('1.8 — Approved push shows attestation info', function () {
     const suffix = `approve-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login(approverUser.username, approverUser.password);
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -263,7 +266,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.10 Canceled push shows Canceled status ---
   it('1.10 — Canceled push shows Canceled status', function () {
     const suffix = `cancel-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login(testUser.username, testUser.password);
     cy.visit(`/dashboard/push/${this.pushId}`);
@@ -286,7 +289,7 @@ describe('Push Details — Tabs & Content Rendering', () => {
   // --- 1.11 Push details page navigates back to push list after action ---
   it('1.11 — Action buttons navigate back to push list after completing action', function () {
     const suffix = `nav-${Date.now()}`;
-    cy.createPush(testUser.username, testUser.password, testUser.email, suffix).as('pushId');
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, suffix).as('pushId');
 
     cy.login(testUser.username, testUser.password);
     cy.visit(`/dashboard/push/${this.pushId}`);

cypress/e2e/push-requests.cy.js

@@ -26,6 +26,9 @@ describe('Push Requests — Tab Filtering', () => {
     password: 'testuser123',
     email: 'pushreq_testuser@example.com',
     gitAccount: 'pushreq_testuser',
+    // Git credentials must match a user on the git server for cy.createPush() to work
+    gitUsername: 'testuser',
+    gitPassword: 'user123',
   };
 
   const approverUser = {
@@ -36,7 +39,7 @@ describe('Push Requests — Tab Filtering', () => {
   };
 
   // Shared push IDs for the test suite
-  const pushIds: { pending: string; approved: string; rejected: string; canceled: string } = {
+  const pushIds = {
     pending: '',
     approved: '',
     rejected: '',
@@ -57,12 +60,12 @@ describe('Push Requests — Tab Filtering', () => {
     cy.logout();
 
     // Create pending push
-    cy.createPush(testUser.username, testUser.password, testUser.email, `pushreq-pending-${Date.now()}`).then(
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, `pushreq-pending-${Date.now()}`).then(
       (id) => { pushIds.pending = id; }
     );
 
     // Create and approve a push
-    cy.createPush(testUser.username, testUser.password, testUser.email, `pushreq-approved-${Date.now()}`).then(
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, `pushreq-approved-${Date.now()}`).then(
       (id) => {
         pushIds.approved = id;
         // Login as approver and approve
@@ -81,7 +84,7 @@ describe('Push Requests — Tab Filtering', () => {
     );
 
     // Create and reject a push
-    cy.createPush(testUser.username, testUser.password, testUser.email, `pushreq-rejected-${Date.now()}`).then(
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, `pushreq-rejected-${Date.now()}`).then(
       (id) => {
         pushIds.rejected = id;
         // Login as approver and reject
@@ -95,7 +98,7 @@ describe('Push Requests — Tab Filtering', () => {
     );
 
     // Create and cancel a push
-    cy.createPush(testUser.username, testUser.password, testUser.email, `pushreq-canceled-${Date.now()}`).then(
+    cy.createPush(testUser.gitUsername, testUser.gitPassword, testUser.email, `pushreq-canceled-${Date.now()}`).then(
       (id) => {
         pushIds.canceled = id;
         // Login as test user and cancel

cypress/e2e/repo-details.cy.js

@@ -40,7 +40,7 @@ describe('Repo Details — User Management', () => {
     gitAccount: 'repo_detail_regular',
   };
 
-  let testRepoId: string | null = null;
+  let testRepoId = null;
 
   function getApiBaseUrl() {
     return Cypress.env('API_BASE_URL') || Cypress.config('baseUrl');

cypress/e2e/repo-list.cy.js

@@ -20,7 +20,7 @@
  * Pagination tested here only. Search/filter use client-side logic.
  */
 describe('Repo List — Search, Filter, Pagination', () => {
-  const createdRepoIds: string[] = [];
+  const createdRepoIds = [];
 
   function getApiBaseUrl() {
     return Cypress.env('API_BASE_URL') || Cypress.config('baseUrl');