chore: remove unused eslint-disable directives

Author: fabiovincenzi

packages/git-proxy-cli/index.js

@@ -460,7 +460,7 @@ yargs(hideBin(process.argv)) // eslint-disable-line @typescript-eslint/no-unused
         default: null,
       },
       authorised: {
-        describe: `Filter for the "authorised" flag of the git push on the list`, // eslint-disable-line max-len
+        describe: `Filter for the "authorised" flag of the git push on the list`,
         demandOption: false,
         type: 'boolean',
         default: null,

packages/git-proxy-cli/test/testCli.test.js

@@ -1,4 +1,3 @@
-/* eslint-disable max-len */
 const helper = require('./testCliUtils');
 
 const path = require('path');

packages/git-proxy-cli/test/testCliUtils.js

@@ -127,7 +127,6 @@ async function closeServer(server, waitTime = 0) {
 async function createCookiesFileWithExpiredCookie() {
   await removeCookiesFile();
   const cookies = [
-    // eslint-disable-next-line max-len
     'connect.sid=s%3AuWjJK_VGFbX9-03UfvoSt_HFU3a0vFOd.jd986YQ17Bw4j1xGJn2l9yiF3QPYhayaYcDqGsNgQY4; Path=/; HttpOnly',
   ];
   fs.writeFileSync(GIT_PROXY_COOKIE_FILE, JSON.stringify(cookies), 'utf8');

test/ConfigLoader.test.js

@@ -329,7 +329,6 @@ describe('ConfigLoader', () => {
     });
 
     it('should load configuration from git repository', async function () {
-      // eslint-disable-next-line no-invalid-this
       this.timeout(10000);
 
       const source = {
@@ -380,7 +379,6 @@ describe('ConfigLoader', () => {
     });
 
     it('should load configuration from http', async function () {
-      // eslint-disable-next-line no-invalid-this
       this.timeout(10000);
 
       const source = {

test/chain.test.js

@@ -59,7 +59,6 @@ const mockPreProcessors = {
   parseAction: sinon.stub(),
 };
 
-// eslint-disable-next-line no-unused-vars
 let mockPushProcessors;
 
 const clearCache = (sandbox) => {

test/integration/forcePush.integration.test.js

@@ -15,7 +15,7 @@ describe('Force Push Integration Test', () => {
   let rebasedCommitSHA;
 
   before(async function () {
-    this.timeout(10000); // eslint-disable-line no-invalid-this
+    this.timeout(10000);
 
     tempDir = path.join(__dirname, '../temp-integration-repo');
     await fs.mkdir(tempDir, { recursive: true });
@@ -58,7 +58,7 @@ describe('Force Push Integration Test', () => {
 
   describe('Complete force push pipeline', () => {
     it('should handle valid diff after rebase scenario', async function () {
-      this.timeout(5000); // eslint-disable-line no-invalid-this
+      this.timeout(5000);
 
       // Create action simulating force push with valid SHAs that have actual changes
       const action = new Action(
@@ -101,7 +101,7 @@ describe('Force Push Integration Test', () => {
     });
 
     it('should handle unreachable commit SHA error', async function () {
-      this.timeout(5000); // eslint-disable-line no-invalid-this
+      this.timeout(5000);
 
       // Invalid SHA to trigger error
       const action = new Action(

test/plugin/plugin.test.js

@@ -16,7 +16,6 @@ const expect = chai.expect;
 const testPackagePath = join(__dirname, '../fixtures', 'test-package');
 
 describe('loading plugins from packages', function () {
-  // eslint-disable-next-line no-invalid-this
   this.timeout(10000);
 
   before(function () {

test/testDb.test.js

@@ -454,7 +454,7 @@ describe('Database clients', async () => {
     console.log('TEST USER:', JSON.stringify(TEST_USER, null, 2));
     console.log('USERS:', JSON.stringify(users, null, 2));
     // remove password as it will have been hashed
-    // eslint-disable-next-line no-unused-vars
+
     const { password: _, ...TEST_USER_CLEAN } = TEST_USER;
     const cleanUsers = cleanResponseData(TEST_USER_CLEAN, users);
     expect(cleanUsers).to.deep.include(TEST_USER_CLEAN);
@@ -500,9 +500,9 @@ describe('Database clients', async () => {
 
   it('should be able to find a user', async function () {
     const user = await db.findUser(TEST_USER.username);
-    // eslint-disable-next-line no-unused-vars
+
     const { password: _, ...TEST_USER_CLEAN } = TEST_USER;
-    // eslint-disable-next-line no-unused-vars
+
     const { password: _2, _id: _3, ...DB_USER_CLEAN } = user;
 
     expect(DB_USER_CLEAN).to.eql(TEST_USER_CLEAN);
@@ -511,7 +511,7 @@ describe('Database clients', async () => {
   it('should be able to filter getUsers', async function () {
     // uppercase the filter value to confirm db client is lowercasing inputs
     const users = await db.getUsers({ username: TEST_USER.username.toUpperCase() });
-    // eslint-disable-next-line no-unused-vars
+
     const { password: _, ...TEST_USER_CLEAN } = TEST_USER;
     const cleanUsers = cleanResponseData(TEST_USER_CLEAN, users);
     expect(cleanUsers[0]).to.eql(TEST_USER_CLEAN);
@@ -564,7 +564,7 @@ describe('Database clients', async () => {
 
     const users = await db.getUsers();
     // remove password as it will have been hashed
-    // eslint-disable-next-line no-unused-vars
+
     const { password: _, ...TEST_USER_CLEAN } = TEST_USER;
     const cleanUsers = cleanResponseData(TEST_USER_CLEAN, users);
     expect(cleanUsers).to.deep.include(TEST_USER_CLEAN);

test/testParsePush.test.js

@@ -129,11 +129,11 @@ describe('parsePackFile', () => {
       user: null,
       steps: [],
       addStep: sandbox.spy(function (step) {
-        this.steps.push(step); // eslint-disable-line no-invalid-this
+        this.steps.push(step);
       }),
       setCommit: sandbox.spy(function (from, to) {
-        this.commitFrom = from; // eslint-disable-line no-invalid-this
-        this.commitTo = to; // eslint-disable-line no-invalid-this
+        this.commitFrom = from;
+        this.commitTo = to;
       }),
     };
 

test/testPush.test.js

@@ -136,7 +136,7 @@ describe('auth', async () => {
       await loginAsApprover();
 
       const commitId =
-        '0000000000000000000000000000000000000000__79b4d8953cbc324bcc1eb53d6412ff89666c241f'; // eslint-disable-line max-len
+        '0000000000000000000000000000000000000000__79b4d8953cbc324bcc1eb53d6412ff89666c241f';
       const res = await chai
         .request(app)
         .get(`/api/v1/push/${commitId}`)