fix(cypress): stabilize profile and auto-approved checks

Author: dcoric

cypress/e2e/profile.cy.js

@@ -103,32 +103,8 @@ describe('Profile Page', () => {
   // --- 5.3 Admin can edit another user's GitHub username ---
   it("5.3 — Admin can edit another user's GitHub username", () => {
     cy.login('admin', 'admin');
-    // Stub both the auth profile call (so AuthProvider/RouteGuard resolve quickly)
-    // and the target user API call to avoid UserProfile throwing on a real API error.
-    cy.intercept('GET', '**/api/auth/profile', {
-      statusCode: 200,
-      body: {
-        username: 'admin',
-        displayName: 'admin',
-        email: 'admin@place.com',
-        title: '',
-        gitAccount: 'none',
-        admin: true,
-      },
-    }).as('getAuthUser');
-    cy.intercept('GET', `**/api/v1/user/${testUser.username}`, {
-      statusCode: 200,
-      body: {
-        username: testUser.username,
-        displayName: 'Profile Test User',
-        email: testUser.email,
-        title: 'QA Tester',
-        gitAccount: testUser.gitAccount,
-        admin: false,
-      },
-    }).as('getUser');
+    cy.intercept('GET', `**/api/v1/user/${testUser.username}`).as('getUser');
     cy.visit(`/dashboard/user/${testUser.username}`);
-    cy.wait('@getAuthUser');
     cy.wait('@getUser');
 
     // Wait for profile to render

src/ui/views/PushDetails/components/AttestationInfo.tsx

@@ -40,9 +40,6 @@ const AttestationInfo: React.FC<AttestationInfoProps> = ({
     return null;
   }
 
-  const reviewerGitAccount =
-    push.attestation.reviewer.gitAccount || push.attestation.reviewer.username;
-
   return (
     <div
       style={{
@@ -79,27 +76,7 @@ const AttestationInfo: React.FC<AttestationInfoProps> = ({
           </p>
         </div>
       ) : (
-        <>
-          {isGitHub && (
-            <UserLink username={push.attestation.reviewer.username}>
-              <img
-                style={{ width: '45px', borderRadius: '20px' }}
-                src={`https://github.com/${reviewerGitAccount}.png`}
-              />
-            </UserLink>
-          )}
-          <div>
-            <p>
-              {isGitHub && (
-                <UserLink username={push.attestation.reviewer.username}>
-                  {reviewerGitAccount}
-                </UserLink>
-              )}
-              {!isGitHub && <UserLink username={push.attestation.reviewer.username} />} approved
-              this contribution
-            </p>
-          </div>
-        </>
+        <ReviewerInfo push={push} isGitHub={isGitHub} />
       )}
 
       <Tooltip
@@ -122,4 +99,40 @@ const AttestationInfo: React.FC<AttestationInfoProps> = ({
   );
 };
 
+interface ReviewerInfoProps {
+  push: PushActionView;
+  isGitHub: boolean;
+}
+
+const ReviewerInfo: React.FC<ReviewerInfoProps> = ({ push, isGitHub }) => {
+  if (!push.attestation?.reviewer) {
+    return null;
+  }
+
+  const reviewerGitAccount =
+    push.attestation.reviewer.gitAccount || push.attestation.reviewer.username;
+
+  return (
+    <>
+      {isGitHub && (
+        <UserLink username={push.attestation.reviewer.username}>
+          <img
+            style={{ width: '45px', borderRadius: '20px' }}
+            src={`https://github.com/${reviewerGitAccount}.png`}
+          />
+        </UserLink>
+      )}
+      <div>
+        <p>
+          {isGitHub && (
+            <UserLink username={push.attestation.reviewer.username}>{reviewerGitAccount}</UserLink>
+          )}
+          {!isGitHub && <UserLink username={push.attestation.reviewer.username} />} approved this
+          contribution
+        </p>
+      </div>
+    </>
+  );
+};
+
 export default AttestationInfo;