refactor: checkAuthorEmails logs refactored and test changed accordingly

Author: RichardUri

src/proxy/processors/push-action/checkAuthorEmails.ts

@@ -39,8 +39,6 @@ const exec = async (req: any, action: Action): Promise<Action> => {
   const illegalEmails = uniqueAuthorEmails.filter((email) => !isEmailAllowed(email));
 
   if (illegalEmails.length > 0) {
-    console.log(`The following commit author e-mails are illegal: ${illegalEmails}`);
-
     step.error = true;
     step.log(`The following commit author e-mails are illegal: ${illegalEmails}`);
     step.setError(
@@ -51,7 +49,7 @@ const exec = async (req: any, action: Action): Promise<Action> => {
     return action;
   }
 
-  console.log(`The following commit author e-mails are legal: ${uniqueAuthorEmails}`);
+  step.log(`The following commit author e-mails are legal: ${uniqueAuthorEmails}`);
   action.addStep(step);
   return action;
 };

test/processors/checkAuthorEmails.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { exec } from '../../src/proxy/processors/push-action/checkAuthorEmails';
-import { Action } from '../../src/proxy/actions';
+import { Action, Step } from '../../src/proxy/actions';
 import * as configModule from '../../src/config';
 import * as validator from 'validator';
 import { CommitData } from '../../src/proxy/processors/types';
@@ -47,7 +47,7 @@ describe('checkAuthorEmails', () => {
     });
 
     // mock console.log to suppress output and verify calls
-    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
+    consoleLogSpy = vi.spyOn(Step.prototype, 'log').mockImplementation(() => {});
 
     // setup mock action
     mockAction = {