Extends type support to include DOMCdataSection and DOMProcessingInstruction in various method signatures

Author: fivefilters

src/Nodes/DOM/DOMNodeList.php

@@ -42,7 +42,7 @@ public function __get($name)
     /**
      * Add node to the list.
      */
-    public function add(DOMNode|DOMElement|DOMText|DOMComment|DOMProcessingInstruction $node): DOMNodeList
+    public function add(DOMNode|DOMElement|DOMText|DOMComment|DOMProcessingInstruction|DOMCdataSection $node): DOMNodeList
     {
         $this->items[] = $node;
         $this->length++;
@@ -53,7 +53,7 @@ public function add(DOMNode|DOMElement|DOMText|DOMComment|DOMProcessingInstructi
     /**
      * Get node.
      */
-    public function item(int $offset): DOMNode|DOMElement|DOMText|DOMComment|DOMProcessingInstruction
+    public function item(int $offset): DOMNode|DOMElement|DOMText|DOMComment|DOMProcessingInstruction|DOMCdataSection
     {
         return $this->items[$offset];
     }

src/Nodes/NodeUtility.php

@@ -9,6 +9,7 @@
 use fivefilters\Readability\Nodes\DOM\DOMText;
 use fivefilters\Readability\Nodes\DOM\DOMComment;
 use fivefilters\Readability\Nodes\DOM\DOMNodeList;
+use fivefilters\Readability\Nodes\DOM\DOMCdataSection;
 
 /**
  * Class NodeUtility.
@@ -121,7 +122,7 @@ public static function removeNode(DOMNode|DOMComment|DOMText|DOMElement $node):
      * Returns the next node. First checks for children (if the flag allows it), then for siblings, and finally
      * for parents.
      */
-    public static function getNextNode(DOMNode|DOMComment|DOMText|DOMElement|DOMDocument|DOMProcessingInstruction $originalNode, bool $ignoreSelfAndKids = false): DOMNode|DOMComment|DOMText|DOMElement|DOMDocument|DOMProcessingInstruction|null
+    public static function getNextNode(DOMNode|DOMComment|DOMText|DOMElement|DOMDocument|DOMProcessingInstruction|DOMCdataSection $originalNode, bool $ignoreSelfAndKids = false): DOMNode|DOMComment|DOMText|DOMElement|DOMDocument|DOMProcessingInstruction|DOMCdataSection|null
     {
         /*
          * Traverse the DOM from node to node, starting at the node passed in.

src/Readability.php

@@ -8,6 +8,7 @@
 use fivefilters\Readability\Nodes\DOM\DOMProcessingInstruction;
 use fivefilters\Readability\Nodes\DOM\DOMText;
 use fivefilters\Readability\Nodes\DOM\DOMComment;
+use fivefilters\Readability\Nodes\DOM\DOMCdataSection;
 use fivefilters\Readability\Nodes\NodeUtility;
 use Psr\Log\LoggerInterface;
 use Masterminds\HTML5;
@@ -961,7 +962,7 @@ private function textSimilarity(string $textA, string $textB): float
     /**
      * Checks if the node is a byline.
      */
-    private function checkByline(DOMNode|DOMText|DOMElement|DOMProcessingInstruction $node, string $matchString): bool
+    private function checkByline(DOMNode|DOMText|DOMElement|DOMProcessingInstruction|DOMCdataSection $node, string $matchString): bool
     {
         if (!$this->configuration->getArticleByline()) {
             return false;
@@ -1755,7 +1756,7 @@ public function _fixLazyImages(DOMDocument $article): void
     /**
      * Remove the style attribute on every e and under.
      **/
-    public function _cleanStyles(DOMDocument|DOMNode|DOMElement|DOMText $node): void
+    public function _cleanStyles(DOMDocument|DOMNode|DOMElement|DOMText|DOMProcessingInstruction|DOMCdataSection $node): void
     {
         if (property_exists($node, 'tagName') && $node->tagName === 'svg') {
             return;