Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Add flow coverage support#108

Merged
orta merged 2 commits intoflow:masterfrom
thymikee:flow-coverage
Apr 9, 2017
Merged

Add flow coverage support#108
orta merged 2 commits intoflow:masterfrom
thymikee:flow-coverage

Conversation

@thymikee
Copy link
Copy Markdown
Contributor

@thymikee thymikee commented Apr 9, 2017

Summary

Flow coverage support.

StatusBar (clicking toggles uncovered code mode):

screen shot 2017-04-09 at 03 29 35

Uncovered code mode:

screen shot 2017-04-09 at 03 29 48

screen shot 2017-04-09 at 03 31 58

@orta
Copy link
Copy Markdown
Contributor

orta commented Apr 9, 2017

Yeah, great - this looks good to me 👍

Very cool

@orta orta merged commit c81434c into flow:master Apr 9, 2017
@thymikee thymikee deleted the flow-coverage branch April 9, 2017 07:31
@jacobk
Copy link
Copy Markdown

jacobk commented May 5, 2017

Is it possible to disable this feature?

I've experienced a big degradation in performance of vscode latley and I've tried to disable most other plugins but cannot find the root cause.

This seems like it could impact performance and I've had performance issues when trying to use flow coverage in the past too.

@thymikee Have you noticed anything similar?

@thymikee
Copy link
Copy Markdown
Contributor Author

thymikee commented May 5, 2017

Coverage report is run for every diagnostic change, and by default the extension sets:

"flow.runOnEdit": true

which tells Flow to get diagnostics (coverage included) on every keystroke.
You can set it to false and see if that makes the difference.

Maybe we could defer it somehow, I'll see what can be done if I have some time to work on it.

@moberemk
Copy link
Copy Markdown

I'm also running into some weirdness with this where I'm getting "uncovered code" on files that don't even Javascript, like bash scripts.

@thymikee
Copy link
Copy Markdown
Contributor Author

@jacobk @moberemk I've addressed couple of perf issues in #126

@moberemk
Copy link
Copy Markdown

moberemk commented May 11, 2017 via email

@thymikee
Copy link
Copy Markdown
Contributor Author

That's fixed too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants