Add bundled flow#118
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| "cross-spawn": "^4.0.0", | ||
| "dequeue": "^1.0.5", | ||
| "event-kit": "^2.0.0", | ||
| "flow": "^0.2.3", |
There was a problem hiding this comment.
I think you're looking for flow-bin instead - this is flow
BrainMaestro
force-pushed
the
add-bundled-flow
branch
from
c1cda37 to
4cfdc23
Compare
|
Yea I missed that. Fixed now |
|
Alright - cool, this looks good - @BrainMaestro can you please add. aCHANGELOG entry to give yourself some credit (you may need to add a master section) other than that - this looks good to go 👍 Nice work |
BrainMaestro
force-pushed
the
add-bundled-flow
branch
2 times, most recently
from
55065f6 to
15a3ec9
Compare
This is used as a third option for users that do not flow installed globally or locally
BrainMaestro
force-pushed
the
add-bundled-flow
branch
from
15a3ec9 to
f69ad33
Compare
|
@orta Thanks! I added a new section to the changelog. Is that the correct way? |
|
Yeah, this is great - thanks @BrainMaestro |
3 participants
Fixes #113