This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Allow workspaceRoot variable in pathToFlow#173
Merged
orta merged 1 commit intoflow:masterfrom Oct 24, 2017
Merged
Conversation
Contributor
|
This is 👍 from me, any chance you can add some docs in the README for this first? |
Contributor
Author
|
Hmm, I won't be able to get to that shortly... I can try to get to it within a few days. |
Contributor
Author
|
(Feel free to merge without if you're comfortable with that, I'm happy to submit a follow-on PR if that's okay by you) |
Contributor
|
👍 that's fine by me, yeah |
rattrayalex
added a commit
to rattrayalex/flow-for-vscode
that referenced
this pull request
Nov 6, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flow.useNPMPackagedFlowwasn't adequate for my use-cases (node_modules not at root, a copy for flow-bin outside of node-modules, etc).I was resorting to this hack:
"postinstall": "cp .vscode/settings.example.json .vscode/settings.json && sed -i '' \"s ROOT_REPLACE_ME $(pwd) \" .vscode/settings.json"Ideally this would be solved by vscode; there is an open issue: microsoft/vscode#2809 however it seems harmless to add this.
I tested locally with:
"flow.pathToFlow": "${workspaceRoot}/my-flow")"flow.pathToFlow": "${workspaceRoot}/my-nonexistent-flow").config('pathToFlow').replacedoes not throw)