This repository was archived by the owner on Dec 19, 2024. It is now read-only.
LSP: make use of relatedInformation for richer diagnostics#258
Merged
orta merged 2 commits intoflow:masterfrom Jul 5, 2018
Merged
LSP: make use of relatedInformation for richer diagnostics#258orta merged 2 commits intoflow:masterfrom
relatedInformation for richer diagnostics#258orta merged 2 commits intoflow:masterfrom
Conversation
thymikee
changed the title
relatedInformation for richer diagnostics withrelatedInformation for richer diagnostics
thymikee
changed the title
relatedInformation for richer diagnosticsrelatedInformation for richer diagnostics
Contributor
|
very cool |
|
this seems to solve this? #254 that would be so awesome |
|
@thymikee is there a way to try that out? |
Contributor
Author
|
@macrozone yup, you're right! |
|
Just merged facebookarchive/flow-language-server#82 and published it as |
thymikee
changed the title
relatedInformation for richer diagnosticsrelatedInformation for richer diagnostics
Contributor
Author
|
Thanks @wbinnssmith, updated! cc @orta |
Contributor
|
Yep, cool! |
Contributor
|
Shipped in 0.8.2 |
|
very nice, this works very well! Btw. should we consider useLSP to be the default? at the moment, it has to be turned on manually |
Contributor
Author
|
Not sure if folks gonna like it, it lacks couple of existing options like run on edit instead of save. But I got couple of folks interested in contributing, so hopefully we'll get to feature parity quicker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just updating the deps to get it working.
This PR is currently blocked by facebookarchive/flow-language-server#82. After this is released, we can update the
flow-language-serverdep once again and get this feature in.Fixes #254
Here's a preview of richer diagnostics (note the links):