Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Fix issue #304#305

Merged
orta merged 2 commits intoflow:masterfrom
Mayank1791989:fix/error-popup
Jan 3, 2019
Merged

Fix issue #304#305
orta merged 2 commits intoflow:masterfrom
Mayank1791989:fix/error-popup

Conversation

@Mayank1791989
Copy link
Copy Markdown
Contributor

No description provided.

I think for now it's better then adding more cases to ignoreFrequentErrors. Later we
can make it a plugin setting.
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@orta
Copy link
Copy Markdown
Contributor

orta commented Jan 3, 2019

OK, cool, yep - nice work

@orta orta merged commit c1ec8f0 into flow:master Jan 3, 2019
@orta
Copy link
Copy Markdown
Contributor

orta commented Jan 3, 2019

Shipped as 1.0.1

@Mayank1791989 Mayank1791989 deleted the fix/error-popup branch January 3, 2019 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants