This repository was archived by the owner on Dec 19, 2024. It is now read-only.
fix(lsp): accept flow release candidate version#344
Merged
orta merged 6 commits intoflow:masterfrom Jun 22, 2019
Merged
Conversation
Mayank1791989
suggested changes
Jun 19, 2019
|
|
||
| export default function assertFlowSupportsLSP(version: string) { | ||
| if (!semver.satisfies(version, FLOW_VERSION_FOR_LSP)) { | ||
| if (!semver.satisfies(version.replace(/-rc/gu, ''), FLOW_VERSION_FOR_LSP)) { |
Contributor
There was a problem hiding this comment.
You need to put the same fix here also https://github.com/flowtype/flow-for-vscode/blob/7bd24accc13cc842c2ff6fce18e37d61b66b53d7/lib/flowLSP/FlowLanguageClient/createMiddleware.js#L25-L28
To avoid logic duplication create separate function in utils and use that function in both places and also add test case for it.
Contributor
There was a problem hiding this comment.
use semver.satisfies(version, FLOW_VERSION_FOR_LSP, { includePrerelease: true })
mroch
previously requested changes
Jun 20, 2019
|
|
||
| export default function assertFlowSupportsLSP(version: string) { | ||
| if (!semver.satisfies(version, FLOW_VERSION_FOR_LSP)) { | ||
| if (!semver.satisfies(version.replace(/-rc/gu, ''), FLOW_VERSION_FOR_LSP)) { |
Contributor
There was a problem hiding this comment.
use semver.satisfies(version, FLOW_VERSION_FOR_LSP, { includePrerelease: true })
Contributor
|
LGTM 👍 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix facebook/flow#7835