Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Ensure that we do not pass a negative number to VS Code for error diagnostics#54

Merged
gabelevi merged 1 commit intoflow:masterfrom
orta:handle_zero_line_errors
Dec 3, 2016
Merged

Ensure that we do not pass a negative number to VS Code for error diagnostics#54
gabelevi merged 1 commit intoflow:masterfrom
orta:handle_zero_line_errors

Conversation

@orta
Copy link
Copy Markdown
Contributor

@orta orta commented Nov 30, 2016

Hello there, looks like if Flow gives an error with 0 as the line, this extension will not show results:

flow status --pretty packages/jest-editor-support/src/test_reconciler.js | pbcopy

{
  "flowVersion":"0.36.0",
  "errors":[
    {
      "kind":"internal",
      "level":"error",
      "message":[
        {
          "context":null,
          "descr":"Internal error: Failure(\"attempt to refine type TestReconcilationState\")\n",
          "type":"Blame",
          "loc":{
            "source":"/Users/orta/dev/projects/vscode/jest/packages/jest-editor-support/src/test_reconciler.js",
            "type":"SourceFile",
            "start":{"line":0,"column":1,"offset":0},
            "end":{"line":0,"column":0,"offset":0}
          },
          "path":"/Users/orta/dev/projects/vscode/jest/packages/jest-editor-support/src/test_reconciler.js",
          "line":0,
          "endline":0,
          "start":1,
          "end":0
        }
      ]
    },
    {
      ...

This fixes that 👍

@gabelevi
Copy link
Copy Markdown
Contributor

gabelevi commented Dec 3, 2016

Awesome! Thanks for the fix! This looks good to me!

@gabelevi gabelevi merged commit 27e5d00 into flow:master Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants