|
| 1 | +/* |
| 2 | +Copyright 2026 The Flux authors |
| 3 | +
|
| 4 | +Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | +you may not use this file except in compliance with the License. |
| 6 | +You may obtain a copy of the License at |
| 7 | +
|
| 8 | + http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | +
|
| 10 | +Unless required by applicable law or agreed to in writing, software |
| 11 | +distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | +See the License for the specific language governing permissions and |
| 14 | +limitations under the License. |
| 15 | +*/ |
| 16 | + |
| 17 | +package controller |
| 18 | + |
| 19 | +import ( |
| 20 | + "context" |
| 21 | + "fmt" |
| 22 | + "testing" |
| 23 | + "time" |
| 24 | + |
| 25 | + "github.com/fluxcd/pkg/apis/meta" |
| 26 | + "github.com/fluxcd/pkg/testserver" |
| 27 | + sourcev1 "github.com/fluxcd/source-controller/api/v1" |
| 28 | + . "github.com/onsi/gomega" |
| 29 | + apimeta "k8s.io/apimachinery/pkg/api/meta" |
| 30 | + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| 31 | + "k8s.io/apimachinery/pkg/types" |
| 32 | + "sigs.k8s.io/controller-runtime/pkg/client" |
| 33 | + |
| 34 | + kustomizev1 "github.com/fluxcd/kustomize-controller/api/v1" |
| 35 | +) |
| 36 | + |
| 37 | +func TestKustomizationReconciler_DirectSourceFetch(t *testing.T) { |
| 38 | + g := NewWithT(t) |
| 39 | + id := "direct-fetch-" + randStringRunes(5) |
| 40 | + revision := "v1.0.0" |
| 41 | + |
| 42 | + err := createNamespace(id) |
| 43 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create test namespace") |
| 44 | + |
| 45 | + err = createKubeConfigSecret(id) |
| 46 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create kubeconfig secret") |
| 47 | + |
| 48 | + manifests := func(name string, data string) []testserver.File { |
| 49 | + return []testserver.File{ |
| 50 | + { |
| 51 | + Name: "configmap.yaml", |
| 52 | + Body: fmt.Sprintf(`--- |
| 53 | +apiVersion: v1 |
| 54 | +kind: ConfigMap |
| 55 | +metadata: |
| 56 | + name: %[1]s |
| 57 | +data: |
| 58 | + key: "%[2]s" |
| 59 | +`, name, data), |
| 60 | + }, |
| 61 | + } |
| 62 | + } |
| 63 | + |
| 64 | + artifact, err := testServer.ArtifactFromFiles(manifests(id, randStringRunes(5))) |
| 65 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create artifact from files") |
| 66 | + |
| 67 | + repositoryName := types.NamespacedName{ |
| 68 | + Name: fmt.Sprintf("direct-fetch-repo-%s", randStringRunes(5)), |
| 69 | + Namespace: id, |
| 70 | + } |
| 71 | + |
| 72 | + err = applyGitRepository(repositoryName, artifact, revision) |
| 73 | + g.Expect(err).NotTo(HaveOccurred()) |
| 74 | + |
| 75 | + kustomizationKey := types.NamespacedName{ |
| 76 | + Name: fmt.Sprintf("direct-fetch-kust-%s", randStringRunes(5)), |
| 77 | + Namespace: id, |
| 78 | + } |
| 79 | + |
| 80 | + t.Run("reconciles with DirectSourceFetch enabled (uses APIReader)", func(t *testing.T) { |
| 81 | + g := NewWithT(t) |
| 82 | + |
| 83 | + // Enable DirectSourceFetch to use APIReader |
| 84 | + reconciler.DirectSourceFetch = true |
| 85 | + defer func() { reconciler.DirectSourceFetch = false }() // Reset after test |
| 86 | + |
| 87 | + kustomization := &kustomizev1.Kustomization{ |
| 88 | + ObjectMeta: metav1.ObjectMeta{ |
| 89 | + Name: kustomizationKey.Name + "-direct", |
| 90 | + Namespace: kustomizationKey.Namespace, |
| 91 | + }, |
| 92 | + Spec: kustomizev1.KustomizationSpec{ |
| 93 | + Interval: metav1.Duration{Duration: reconciliationInterval}, |
| 94 | + Path: "./", |
| 95 | + KubeConfig: &meta.KubeConfigReference{ |
| 96 | + SecretRef: &meta.SecretKeyReference{ |
| 97 | + Name: "kubeconfig", |
| 98 | + }, |
| 99 | + }, |
| 100 | + SourceRef: kustomizev1.CrossNamespaceSourceReference{ |
| 101 | + Name: repositoryName.Name, |
| 102 | + Namespace: repositoryName.Namespace, |
| 103 | + Kind: sourcev1.GitRepositoryKind, |
| 104 | + }, |
| 105 | + TargetNamespace: id, |
| 106 | + }, |
| 107 | + } |
| 108 | + |
| 109 | + g.Expect(k8sClient.Create(context.Background(), kustomization)).To(Succeed()) |
| 110 | + t.Cleanup(func() { |
| 111 | + g.Expect(k8sClient.Delete(context.Background(), kustomization)).To(Succeed()) |
| 112 | + }) |
| 113 | + |
| 114 | + resultK := &kustomizev1.Kustomization{} |
| 115 | + g.Eventually(func() bool { |
| 116 | + _ = k8sClient.Get(context.Background(), client.ObjectKeyFromObject(kustomization), resultK) |
| 117 | + return apimeta.IsStatusConditionTrue(resultK.Status.Conditions, meta.ReadyCondition) && |
| 118 | + resultK.Status.LastAppliedRevision == revision |
| 119 | + }, timeout, time.Second).Should(BeTrue()) |
| 120 | + }) |
| 121 | + |
| 122 | + t.Run("source not found with DirectSourceFetch enabled", func(t *testing.T) { |
| 123 | + g := NewWithT(t) |
| 124 | + |
| 125 | + // Enable DirectSourceFetch to use APIReader |
| 126 | + reconciler.DirectSourceFetch = true |
| 127 | + defer func() { reconciler.DirectSourceFetch = false }() // Reset after test |
| 128 | + |
| 129 | + kustomization := &kustomizev1.Kustomization{ |
| 130 | + ObjectMeta: metav1.ObjectMeta{ |
| 131 | + Name: kustomizationKey.Name + "-notfound", |
| 132 | + Namespace: kustomizationKey.Namespace, |
| 133 | + }, |
| 134 | + Spec: kustomizev1.KustomizationSpec{ |
| 135 | + Interval: metav1.Duration{Duration: reconciliationInterval}, |
| 136 | + Path: "./", |
| 137 | + KubeConfig: &meta.KubeConfigReference{ |
| 138 | + SecretRef: &meta.SecretKeyReference{ |
| 139 | + Name: "kubeconfig", |
| 140 | + }, |
| 141 | + }, |
| 142 | + SourceRef: kustomizev1.CrossNamespaceSourceReference{ |
| 143 | + Name: "non-existent-repo", |
| 144 | + Namespace: id, |
| 145 | + Kind: sourcev1.GitRepositoryKind, |
| 146 | + }, |
| 147 | + TargetNamespace: id, |
| 148 | + }, |
| 149 | + } |
| 150 | + |
| 151 | + g.Expect(k8sClient.Create(context.Background(), kustomization)).To(Succeed()) |
| 152 | + t.Cleanup(func() { |
| 153 | + g.Expect(k8sClient.Delete(context.Background(), kustomization)).To(Succeed()) |
| 154 | + }) |
| 155 | + |
| 156 | + resultK := &kustomizev1.Kustomization{} |
| 157 | + g.Eventually(func() bool { |
| 158 | + _ = k8sClient.Get(context.Background(), client.ObjectKeyFromObject(kustomization), resultK) |
| 159 | + ready := apimeta.FindStatusCondition(resultK.Status.Conditions, meta.ReadyCondition) |
| 160 | + if ready == nil { |
| 161 | + return false |
| 162 | + } |
| 163 | + return ready.Status == metav1.ConditionFalse && |
| 164 | + ready.Reason == meta.ArtifactFailedReason |
| 165 | + }, timeout, time.Second).Should(BeTrue()) |
| 166 | + }) |
| 167 | +} |
| 168 | + |
| 169 | +func TestKustomizationReconciler_DirectSourceFetch_OCIRepository(t *testing.T) { |
| 170 | + g := NewWithT(t) |
| 171 | + id := "direct-fetch-oci-" + randStringRunes(5) |
| 172 | + |
| 173 | + err := createNamespace(id) |
| 174 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create test namespace") |
| 175 | + |
| 176 | + err = createKubeConfigSecret(id) |
| 177 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create kubeconfig secret") |
| 178 | + |
| 179 | + t.Run("handles OCIRepository with DirectSourceFetch enabled", func(t *testing.T) { |
| 180 | + g := NewWithT(t) |
| 181 | + |
| 182 | + // Enable DirectSourceFetch to use APIReader |
| 183 | + reconciler.DirectSourceFetch = true |
| 184 | + defer func() { reconciler.DirectSourceFetch = false }() // Reset after test |
| 185 | + |
| 186 | + // Create an OCIRepository (without artifact - just to test source fetching) |
| 187 | + ociRepoName := types.NamespacedName{ |
| 188 | + Name: fmt.Sprintf("oci-repo-%s", randStringRunes(5)), |
| 189 | + Namespace: id, |
| 190 | + } |
| 191 | + |
| 192 | + ociRepo := &sourcev1.OCIRepository{ |
| 193 | + ObjectMeta: metav1.ObjectMeta{ |
| 194 | + Name: ociRepoName.Name, |
| 195 | + Namespace: ociRepoName.Namespace, |
| 196 | + }, |
| 197 | + Spec: sourcev1.OCIRepositorySpec{ |
| 198 | + URL: "oci://ghcr.io/test/repo", |
| 199 | + Interval: metav1.Duration{Duration: time.Minute}, |
| 200 | + }, |
| 201 | + } |
| 202 | + g.Expect(k8sClient.Create(context.Background(), ociRepo)).To(Succeed()) |
| 203 | + t.Cleanup(func() { |
| 204 | + g.Expect(k8sClient.Delete(context.Background(), ociRepo)).To(Succeed()) |
| 205 | + }) |
| 206 | + |
| 207 | + kustomization := &kustomizev1.Kustomization{ |
| 208 | + ObjectMeta: metav1.ObjectMeta{ |
| 209 | + Name: fmt.Sprintf("kust-oci-%s", randStringRunes(5)), |
| 210 | + Namespace: id, |
| 211 | + }, |
| 212 | + Spec: kustomizev1.KustomizationSpec{ |
| 213 | + Interval: metav1.Duration{Duration: reconciliationInterval}, |
| 214 | + Path: "./", |
| 215 | + KubeConfig: &meta.KubeConfigReference{ |
| 216 | + SecretRef: &meta.SecretKeyReference{ |
| 217 | + Name: "kubeconfig", |
| 218 | + }, |
| 219 | + }, |
| 220 | + SourceRef: kustomizev1.CrossNamespaceSourceReference{ |
| 221 | + Name: ociRepoName.Name, |
| 222 | + Namespace: ociRepoName.Namespace, |
| 223 | + Kind: sourcev1.OCIRepositoryKind, |
| 224 | + }, |
| 225 | + TargetNamespace: id, |
| 226 | + }, |
| 227 | + } |
| 228 | + |
| 229 | + g.Expect(k8sClient.Create(context.Background(), kustomization)).To(Succeed()) |
| 230 | + t.Cleanup(func() { |
| 231 | + g.Expect(k8sClient.Delete(context.Background(), kustomization)).To(Succeed()) |
| 232 | + }) |
| 233 | + |
| 234 | + // The kustomization should be able to find the source (even though it has no artifact) |
| 235 | + // and eventually report that the artifact is not ready |
| 236 | + resultK := &kustomizev1.Kustomization{} |
| 237 | + g.Eventually(func() bool { |
| 238 | + _ = k8sClient.Get(context.Background(), client.ObjectKeyFromObject(kustomization), resultK) |
| 239 | + // Source should be found but artifact should not be ready |
| 240 | + return len(resultK.Status.Conditions) > 0 |
| 241 | + }, timeout, time.Second).Should(BeTrue()) |
| 242 | + }) |
| 243 | +} |
| 244 | + |
| 245 | +func TestKustomizationReconciler_DirectSourceFetch_Bucket(t *testing.T) { |
| 246 | + g := NewWithT(t) |
| 247 | + id := "direct-fetch-bucket-" + randStringRunes(5) |
| 248 | + |
| 249 | + err := createNamespace(id) |
| 250 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create test namespace") |
| 251 | + |
| 252 | + err = createKubeConfigSecret(id) |
| 253 | + g.Expect(err).NotTo(HaveOccurred(), "failed to create kubeconfig secret") |
| 254 | + |
| 255 | + t.Run("handles Bucket with DirectSourceFetch enabled", func(t *testing.T) { |
| 256 | + g := NewWithT(t) |
| 257 | + |
| 258 | + // Enable DirectSourceFetch to use APIReader |
| 259 | + reconciler.DirectSourceFetch = true |
| 260 | + defer func() { reconciler.DirectSourceFetch = false }() // Reset after test |
| 261 | + |
| 262 | + // Create a Bucket source (without artifact - just to test source fetching) |
| 263 | + bucketName := types.NamespacedName{ |
| 264 | + Name: fmt.Sprintf("bucket-%s", randStringRunes(5)), |
| 265 | + Namespace: id, |
| 266 | + } |
| 267 | + |
| 268 | + bucket := &sourcev1.Bucket{ |
| 269 | + ObjectMeta: metav1.ObjectMeta{ |
| 270 | + Name: bucketName.Name, |
| 271 | + Namespace: bucketName.Namespace, |
| 272 | + }, |
| 273 | + Spec: sourcev1.BucketSpec{ |
| 274 | + BucketName: "test-bucket", |
| 275 | + Endpoint: "s3.amazonaws.com", |
| 276 | + Interval: metav1.Duration{Duration: time.Minute}, |
| 277 | + }, |
| 278 | + } |
| 279 | + g.Expect(k8sClient.Create(context.Background(), bucket)).To(Succeed()) |
| 280 | + t.Cleanup(func() { |
| 281 | + g.Expect(k8sClient.Delete(context.Background(), bucket)).To(Succeed()) |
| 282 | + }) |
| 283 | + |
| 284 | + kustomization := &kustomizev1.Kustomization{ |
| 285 | + ObjectMeta: metav1.ObjectMeta{ |
| 286 | + Name: fmt.Sprintf("kust-bucket-%s", randStringRunes(5)), |
| 287 | + Namespace: id, |
| 288 | + }, |
| 289 | + Spec: kustomizev1.KustomizationSpec{ |
| 290 | + Interval: metav1.Duration{Duration: reconciliationInterval}, |
| 291 | + Path: "./", |
| 292 | + KubeConfig: &meta.KubeConfigReference{ |
| 293 | + SecretRef: &meta.SecretKeyReference{ |
| 294 | + Name: "kubeconfig", |
| 295 | + }, |
| 296 | + }, |
| 297 | + SourceRef: kustomizev1.CrossNamespaceSourceReference{ |
| 298 | + Name: bucketName.Name, |
| 299 | + Namespace: bucketName.Namespace, |
| 300 | + Kind: sourcev1.BucketKind, |
| 301 | + }, |
| 302 | + TargetNamespace: id, |
| 303 | + }, |
| 304 | + } |
| 305 | + |
| 306 | + g.Expect(k8sClient.Create(context.Background(), kustomization)).To(Succeed()) |
| 307 | + t.Cleanup(func() { |
| 308 | + g.Expect(k8sClient.Delete(context.Background(), kustomization)).To(Succeed()) |
| 309 | + }) |
| 310 | + |
| 311 | + // The kustomization should be able to find the source (even though it has no artifact) |
| 312 | + resultK := &kustomizev1.Kustomization{} |
| 313 | + g.Eventually(func() bool { |
| 314 | + _ = k8sClient.Get(context.Background(), client.ObjectKeyFromObject(kustomization), resultK) |
| 315 | + // Source should be found but artifact should not be ready |
| 316 | + return len(resultK.Status.Conditions) > 0 |
| 317 | + }, timeout, time.Second).Should(BeTrue()) |
| 318 | + }) |
| 319 | +} |
0 commit comments